From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Blog: Guix packaging tutorial Date: Thu, 27 Sep 2018 19:34:56 +0200 Message-ID: <87wor6269r.fsf@ambrevar.xyz> References: <87in397jsd.fsf@ambrevar.xyz> <20180913191151.GA1865@jurong> <87woro5ocf.fsf@ambrevar.xyz> <20180914113302.elqrk3tvdkln2cde@thebird.nl> <87o9cmj0fc.fsf@ambrevar.xyz> <87mus6iypf.fsf@ambrevar.xyz> <87lg7n3vjh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5aBr-0006cy-PR for guix-devel@gnu.org; Thu, 27 Sep 2018 13:35:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5aBq-0000n3-W9 for guix-devel@gnu.org; Thu, 27 Sep 2018 13:35:03 -0400 In-reply-to: <87lg7n3vjh.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel , guix-blog@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for this thorough review, Ludovic! I've taken most of your comments into account. A few more questions: > s/conventionally.*/typically used for read-only global variables/ But aren't they generated in scope? I think we should mention this, or else new users try to access them out of scope. > It doesn=E2=80=99t make much sense to propagate a tarball, does it? Not really, but I just wanted to use "propagated input". We need a better example. Any idea? > > The astute reader may have noticed the quasi-quote and comma syntax in = the > > argument field. Indeed, the build code in the package declaration shou= ld not be > > evaluated on the client side, but only when passed to the Guix daemon. = This > > mechanism of passing code around two running processes is called [[http= s://arxiv.org/abs/1709.00833][code staging]]. > > See [[https://www.gnu.org/software/guix/manual/en/html_node/G_002dExpre= ssions.html][the "G-Expressions" chapter]] from the manual. > > Though precisely package definitions don=E2=80=99t use gexps yet=E2=80=A6= Not sure if > we should mention it; maybe it=E2=80=99s outside the scope of this tutori= al. Hmmm... I think it's important to mention why code is not evaluated. Maybe= this rather obscure paragraph could be simplified? I'll remove the mention to G-exp, it does not belong here indeed. > > See https://guix.info/contact/ for the mailing lists, IRC, etc. > > For now please use gnu.org/software/guix URLs. Ok for this one, but I'd also like to link to the channels section in the manual, but it's not on gnu.org. Or is it? Last but not least, what should I do next? Should we wait for more reviews? Should I go ahead and push to master? Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlutFMAACgkQm9z0l6S7 zH+GRgf8Do070Byb1VkOxW6g/zEjBvriCaT3wKvT1x0UZFe3Y6lY7WOPWFirEg/V PEuCvqSv5vnF7wWTnpk/KlBCQ2cxEJvAls+/LtPaOi6IRY5l7T6wHZj8TiOR1Nfm 0HQ7zyIEOUcJm01GtmxOuciDwqZyOjkXD5RgD8fNp6B6unnpLihZuQXR8ry7WLZI wScktCkbi8Qe7PwD011zOaVAZKmeMnWQOZLGgRcvALK9RWa4S+kEPiKmdBKl0X7y InAUPbqI5Q/7STRM/O7t8TkeTGqZOAmPTiYRuELRYNOr+WkVVNJGsL74hgi8UoG8 hi3KVpTzsxtrrG/GLkSs3es0TIe7Jw== =dz/j -----END PGP SIGNATURE----- --=-=-=--