From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: Octave & QtOctave Date: Tue, 04 Dec 2018 15:53:07 -0500 Message-ID: <87woopovyk.fsf@posteo.net> References: <875zwnqomz.fsf@posteo.net> <87a7lyzkk2.fsf@gmail.com> <20181124221022.ankjuz4mdpkoohkn@abyayala> <87k1l1w3n0.fsf@gnu.org> <87in0ijtku.fsf@posteo.net> <87va4h5vhr.fsf@gnu.org> <87a7lnk9sb.fsf@posteo.net> <871s6xz894.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUHh7-0003hs-4Q for guix-devel@gnu.org; Tue, 04 Dec 2018 15:53:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUHh2-00062E-A9 for guix-devel@gnu.org; Tue, 04 Dec 2018 15:53:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]:33255) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gUHh1-00060Y-CZ for guix-devel@gnu.org; Tue, 04 Dec 2018 15:53:20 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 15C82240101 for ; Tue, 4 Dec 2018 21:53:16 +0100 (CET) In-Reply-To: <871s6xz894.fsf@gmail.com> (Alex Vong's message of "Tue, 04 Dec 2018 22:17:27 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Vong Cc: guix-devel --=-=-= Content-Type: text/plain Alex Vong writes: > Hello Kei, > > Kei Kebreau writes: > > [...] >> >> Here are two tentative patches that make the changes we've discussed. >> Also, should we make a deprecated-package definition for qtoctave? > > I think some additional changes related to "(assoc-ref inputs ..." > needed to be made. Otherwise, looks good to me! Here is a patch I made > earlier but it was not tested, feel free to cherry-pick what is needed: > > From 2b04caa66c17da257dfb4f4ccb94e8d629b95e53 Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Mon, 3 Dec 2018 03:39:40 +0800 > Subject: [PATCH] gnu: Rename "octave" to "octave-cli" and "qtoctave" to > "octave". > > * gnu/packages/maths.scm (octave): Rename to octave-cli. > [name]: Change to "octave-cli". > (qtoctave): Rename to octave. > [name]: Change to "octave". > [inherit]: Inherit from octave-cli. > [source]: Likewise. > [inputs]: Likewise. > [native-inputs]: Likewise. > [arguments]: Likewise. > (flann): Update accordingly. > * gnu/packages/engineering.scm (qucs): Likewise. > (qucs-s): Likewise. > * gnu/packages/machine-learning.scm (shogun): Likewise. ... > - ("octave" ,octave) > + ("octave-cli" ,octave-cli) I see the main difference is that you've replace the package's associated string to "octave-cli" as well as the name, whereas I've only replaced the package name. Should I replace the associated package string, too? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlwG6TMACgkQ5qXuPBlG eg2ZOw/9Ht16nva+PyZuB8iUAK94GqiM0DswKqfbn0nkXFHe3WxEZTaOEx7/GcwL GyU/518XluGQ/BOifHzTxzvgsm8RRYYYNdFXjHEuG6ry3nsB6y3y6awGmdxogg5s oQlMeV0/OCKSkjbr5BEPGWn04Eqi07iQHYeLF+heOmEtVPKSckkmzCEb5IdDHvcQ 9ZBI4jNziSie3qhI3WFD1/N4TJcDo+NGJvTLrBzSi9GN7Dr1oLmHNkEs/SthCjiR 3OgF4Lkb0htT+/GxBTx8x/YewdIgLDmZAK2k1uO33yp2fQG+CSB2X8cnZIatgVcA Nal4HQnwbLzt7osHMTnHxVk3TSlNP+e2vbTq8MnOTbCtsKv2QaU8/QlFrn//wkOH 41s1Iqe0ttcdLhQgDYxQ4CpI8xK4qk3zWNrgpT6fxkRJzBbd8Kgwuxpldz1AaC5P Uf8+PVxoeH4PnkZUMpxXJJRgvE2q4JEhKq8jqLV3N47tp5WLQY8AOCy+83psyeIA UPZisWpDWAacLJpugQWWF0KPfjIw7RNGH7MI5d6sG14HiUkGUIb354fXcHp/QQKP u/lcPVAF/gk3/SpLE3EcFA+56niYqlNPXs+xndX4hQ9+0ag9Wr/Gci33n5JTy0gY nnAsjmDehiS6SbH8QJ/jyd/Ou9kw/NrwSO0tRlLcseKccizrUI8= =MEhk -----END PGP SIGNATURE----- --=-=-=--