From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Fixing evolution-data-server on core-updates
Date: Mon, 15 Jul 2019 09:50:14 -0400 [thread overview]
Message-ID: <87wogjmmp5.fsf@posteo.net> (raw)
In-Reply-To: <87tvbnmpyg.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 15 Jul 2019 14:39:51 +0200")
Ludovic Courtès <ludo@gnu.org> writes:
> Hello Timothy,
>
> Timothy Sample <samplet@ngyro.com> skribis:
>
>> From bcd753f777687c52bba6b9bf4184879e69990118 Mon Sep 17 00:00:00 2001
>> From: Timothy Sample <samplet@ngyro.com>
>> Date: Sun, 14 Jul 2019 23:47:44 -0400
>> Subject: [PATCH] gnu: evolution-data-server: Fix locale issue.
>>
>> * gnu/packages/gnome.scm (evolution-data-server)[arguments]: Add a phase
>> that patches the source code to fix a locale issue.
>> ---
>> gnu/packages/gnome.scm | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index eb251498e9..a34adc4006 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -5168,6 +5168,21 @@ Exchange, Last.fm, IMAP/SMTP, Jabber, SIP and Kerberos.")
>> "tests/libedata-cal/test-cal-cache-utils.c")
>> (("/bin/rm") (which "rm")))
>> #t))
>> + ;; This phase fixes locale canonicalization and prevents a few test
>> + ;; failures. The bug has been reported upstream:
>> + ;; <https://gitlab.gnome.org/GNOME/evolution-data-server/issues/137>.
>> + (add-after 'unpack 'patch-locale-canonicalization
>> + (lambda _
>> + (substitute* "src/libedataserver/e-collator.c"
>> + (("len = uloc_canonicalize \\(posix_locale,.*" x)
>> + ((lambda (xs) (string-join xs "\n" 'suffix))
>> + (list
>> + "if (g_ascii_strcasecmp(posix_locale, \"C\") == 0 ||"
>> + " g_ascii_strcasecmp(posix_locale, \"POSIX\") == 0) {"
>> + " posix_locale = \"en_US_POSIX\";"
>> + "}"
>> + x))))
>
> LGTM, thanks for fixing it!
>
> Ludo’.
Just FYI, I can confirm that this patch allows me to re-enable tests
that previously failed on core-updates! I've re-enabled the relevant
failing tests on my own core-updates branch in anticipation of this
patch. Thanks from me, too!
Kei
next prev parent reply other threads:[~2019-07-15 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 4:09 Fixing evolution-data-server on core-updates Timothy Sample
2019-07-15 12:39 ` Ludovic Courtès
2019-07-15 13:50 ` Kei Kebreau [this message]
2019-07-16 13:42 ` Timothy Sample
2019-07-16 10:32 ` Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wogjmmp5.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).