From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Guix pull chokes on uglify-js Date: Thu, 28 Nov 2019 21:47:44 +0100 Message-ID: <87wobjiv7z.fsf@ambrevar.xyz> References: <87v9r393i6.fsf@nckx> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50235) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaQhi-0005Ya-9q for guix-devel@gnu.org; Thu, 28 Nov 2019 15:47:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaQhb-0008Kp-LI for guix-devel@gnu.org; Thu, 28 Nov 2019 15:47:52 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58641) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaQhb-00081a-DG for guix-devel@gnu.org; Thu, 28 Nov 2019 15:47:51 -0500 In-Reply-To: <87v9r393i6.fsf@nckx> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice , Guix Devel , Ricardo Wurmus --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sorry about that, guix didn't complain at compile time and every looked fine, but apparently I missed something :( On closer look, I think I found the culprit: we have a minify build system and in guix/build-system/minify.scm we define the default-uglify-js procedure which retrieves uglify-js from the lisp module. I assume the following would do the trick: =2D-8<---------------cut here---------------start------------->8--- (define (default-uglify-js) "Return the default package to minify JavaScript source files." ;; Lazily resolve the binding to avoid a circular dependency. (let ((js-mod (resolve-interface '(gnu packages javascript)))) (module-ref js-mod 'uglify-js))) =2D-8<---------------cut here---------------end--------------->8--- Does that sound reasonable? Ricardo? By the way, is there a convenient way to catch this kind of errors without pushing to master first? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl3gMnAACgkQm9z0l6S7 zH8vVQgArMdL4LoHnUT2eRPUQBA87CQyDvlxpcQPrHFBDCQt71W1rUboJZTdVHZB C4gwJNaTAObicEv9BpMopicr7i4K7qzTHAP07ydZNGnQaQCsBDV9jNWSkLAOCMKz bnrosDnPGHbg0lsCTJofFGlrJp/pRNJ+Dk/2GMBBjNC8e6x9Lm9MxOoaV7uaKY1e 3VVyZklZD+1u7mHmnnRrBszYu9TWXCvJbT6l3xGNiV39YS4gtS9356i0xMWWZ6mv wcVZOwTBoyQhdkC+buh/z9SHsY51EGPhq0lfT9YcGHQCadCb7KB3PY5UH34o5Wv/ XVM+r1Bj5QBxR7qOgIX9un2EHJPusA== =C29P -----END PGP SIGNATURE----- --=-=-=--