From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Tobias Geerinckx-Rice <me@tobias.gr>,
Guix Devel <guix-devel@gnu.org>,
Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Guix pull chokes on uglify-js
Date: Thu, 28 Nov 2019 21:47:44 +0100 [thread overview]
Message-ID: <87wobjiv7z.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87v9r393i6.fsf@nckx>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Sorry about that, guix didn't complain at compile time and every looked
fine, but apparently I missed something :(
On closer look, I think I found the culprit: we have a minify build
system and in guix/build-system/minify.scm we define the
default-uglify-js procedure which retrieves uglify-js from the lisp
module.
I assume the following would do the trick:
--8<---------------cut here---------------start------------->8---
(define (default-uglify-js)
"Return the default package to minify JavaScript source files."
;; Lazily resolve the binding to avoid a circular dependency.
(let ((js-mod (resolve-interface '(gnu packages javascript))))
(module-ref js-mod 'uglify-js)))
--8<---------------cut here---------------end--------------->8---
Does that sound reasonable?
Ricardo?
By the way, is there a convenient way to catch this kind of errors
without pushing to master first?
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-11-28 20:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 19:58 Guix pull chokes on uglify-js Tobias Geerinckx-Rice
2019-11-28 20:47 ` Pierre Neidhardt [this message]
2019-11-29 14:42 ` Pierre Neidhardt
2019-11-29 15:25 ` zimoun
2019-12-02 9:35 ` Pierre Neidhardt
2019-12-05 12:50 ` Pierre Neidhardt
2019-12-05 14:46 ` Tobias Geerinckx-Rice
2019-12-05 14:54 ` Pierre Neidhardt
2019-12-05 14:55 ` Tobias Geerinckx-Rice
2019-12-05 15:03 ` Pierre Neidhardt
2019-12-05 15:12 ` Marius Bakke
2019-12-05 15:19 ` Pierre Neidhardt
2019-12-05 15:37 ` Pierre Neidhardt
2019-12-05 16:06 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wobjiv7z.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).