From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Packaging Jami progress Date: Thu, 05 Dec 2019 15:32:23 +0100 Message-ID: <87wobac07c.fsf@ambrevar.xyz> References: <20191104214754.793ec2ff@interia.pl> <20191125221517.1140d0c9@kompiuter> <874kyrlzmn.fsf@ambrevar.xyz> <20191126203259.0f4141ea@kompiuter> <20191130192121.11e0c968@kompiuter> <87fti52or5.fsf@ambrevar.xyz> <20191201173411.042e68f2@kompiuter> <878snw2bpn.fsf@ambrevar.xyz> <20191203164402.77a8c728@interia.pl> <87tv6hieeg.fsf@ambrevar.xyz> <20191203190235.53765cba@kompiuter> <87fti1mf1u.fsf@ambrevar.xyz> <87d0d5mez0.fsf@ambrevar.xyz> <20191204153631.509b9afb@interia.pl> <87immwt8kh.fsf@ambrevar.xyz> <20191204165038.7a5403f2@interia.pl> <87fti0t6rr.fsf@ambrevar.xyz> <20191204175614.29f663cd@kompiuter> <87a788t47g.fsf@ambrevar.xyz> <20191204182249.38fd0700@interia.pl> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56270) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icsBA-0000YC-OW for guix-devel@gnu.org; Thu, 05 Dec 2019 09:32:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icsB8-0002an-Vs for guix-devel@gnu.org; Thu, 05 Dec 2019 09:32:28 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:51745) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icsB8-0002Qu-MD for guix-devel@gnu.org; Thu, 05 Dec 2019 09:32:26 -0500 In-Reply-To: <20191204182249.38fd0700@interia.pl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Wielkiewicz Cc: Guix-devel --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks! The first 5 commits look good overall. For the last one, I think there are a few confusions: =2D native-inputs takes packages or origins, it does not take a lambda. =2D To call a custom function from the builder, you need to include the module that defines it for the build system, e.g. (arguments `(#:modules ((gnu packages telephony) ,@%gnu-build-system-modules) ...) =2D In this particular case, you could even make a macro that is expanded at definition time, so that you would not even need to import the module. If you don't know how to write scheme macros, no need to go down this road for now. But before fixing this issue, what are you trying to do exactly? Do you intend to reuse this `jami-apply-dependency-patches' procedure somewhere else? On a different topic, to avoid sending patch archives in the future, you could use a public repository clone of Guix. There are a couple of free services out there, like sr.ht, maybe gogs.io, etc. This would make it smoother to track your progress and help you in the proc= ess. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl3pFPcACgkQm9z0l6S7 zH9Guwf9HTvPP2ppbVwC97Yct+1e5qVfLVwnrrWxAcOHLl/u1oejmfumf0c6lW3c qjln0HcPRe3F+xAy9N8tzKO4PiwuPtRUa7qTgpE9yvooFFW7CZOSA7l/N9HR7Hyz e4acGulAma94MkzHZgmgrpLg4w23zcc1kOeSNqfhMWHqfORGtgKmCaFH2MNius2g 9ZQ9v8nY5HAk115Fq18HcjDjr9cK7h/4G3iSsN295nzjZ9Wjm5t6vmVlapKE6bis 5PTZEM0kwLj2Eb4U1D+TET26LH+xFiVY1UEIh60XvaToHlwQb3Ga1GtBZs8iUdH4 lbFX+lbgaLKNrEpiaiY/TeIF4mkXOQ== =InLC -----END PGP SIGNATURE----- --=-=-=--