From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Remarks about commit 2c82d4ad10de8
Date: Mon, 16 Dec 2019 16:13:27 +0100
Message-ID: <87woawgv6w.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:52678)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <m.othacehe@gmail.com>) id 1igs41-0001LM-7y
 for guix-devel@gnu.org; Mon, 16 Dec 2019 10:13:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <m.othacehe@gmail.com>) id 1igs3w-0002ro-2t
 for guix-devel@gnu.org; Mon, 16 Dec 2019 10:13:37 -0500
Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:43119)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <m.othacehe@gmail.com>)
 id 1igs3v-0002q9-RW
 for guix-devel@gnu.org; Mon, 16 Dec 2019 10:13:32 -0500
Received: by mail-wr1-x434.google.com with SMTP id d16so7703114wre.10
 for <guix-devel@gnu.org>; Mon, 16 Dec 2019 07:13:31 -0800 (PST)
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Brett Gilio <brettg@posteo.net>
Cc: Guix-devel <guix-devel@gnu.org>


Hello Brett,

I have a few remarks on the aforementioned commit.

> +       (list (string-append "-DCMAKE_CXX_FLAGS='-isystem "
> +                            (assoc-ref %build-inputs "gcc")
> +                            "/include/c++'"))))

Why is this needed? The following snippet in clang-from-llvm isn't enough?

--8<---------------cut here---------------start------------->8---
;; Make clang look for libstdc++ in the right
;; location.
(("LibStdCXXIncludePathCandidates\\[\\] = \\{")
 (string-append
  "LibStdCXXIncludePathCandidates[] = { \"" gcc "/include/c++\","))
--8<---------------cut here---------------end--------------->8---

> +     (inputs
>       `(("clang" ,clang)
> -       ("llvm" ,llvm)))
> +       ("ncurses" ,ncurses)))
> +    (native-inputs
> +     `(("rapidjson" ,rapidjson)

Rapidjson is an input (even if ccls is not linked against because its a
header-only library).

> +       ("gcc" ,gcc)))

This shouldn't be needed as it is an implicit input.

Thanks,

Mathieu