Hello, I need someone to push this commit: https://lists.gnu.org/archive/html/guix-patches/2020-07/msg00226.html From this version, my toaster can't build opendht anymore and I'm stuck on Fedora on my newer now, where I have no Guix available. Can someone check if it compiles and push, so I can get back to working on Jami? The latest Jami version requires opendht 2.1.4. Jan Wielkiewicz
[-- Attachment #1: Type: text/plain, Size: 588 bytes --] Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes: > I need someone to push this commit: > https://lists.gnu.org/archive/html/guix-patches/2020-07/msg00226.html > > From this version, my toaster can't build opendht anymore and I'm stuck > on Fedora on my newer now, where I have no Guix available. > Can someone check if it compiles and push, so I can get > back to working on Jami? The latest Jami version requires opendht > 2.1.4. Looks fine to me, I've made some minor tweaks to the commit message, and pushed as 143188423a727426efdc6289fc87a5e492bcf09d. Thanks, Chris [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 962 bytes --]
Hello, Seems opendht is fine, but Jami just fails during compilation. Reported the issue here: https://git.jami.net/savoirfairelinux/ring-daemon/issues/261 It seems they build their package with meson now, but libring requires meson 0.54 or higher. Tried upgrading it quickly and dirty but glib or glibc failed to compile. I can't do anything until developers fix this or someone bumps meson, sorry. Jan Wielkiewicz
Hello, Jami devs helped me - it turns out opendht 2.1.4 contains a bug, which was fixed on master. I can either wait for the next version where it works or add the commit fixing the bug as a patch. Opendht in Jami was bumped though, I can't downgrade in my wip. What do you think? Jan Wielkiewicz
[-- Attachment #1: Type: text/plain, Size: 584 bytes --] Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes: > Jami devs helped me - it turns out opendht 2.1.4 contains a bug, which > was fixed on master. I can either wait for the next version where it > works or add the commit fixing the bug as a patch. Opendht in Jami was > bumped though, I can't downgrade in my wip. In this case the common procedure is to add a (non-public) opendht-jami package at the right commit. This package can then safely be deleted when the next version of opendht comes out. Cheers! -- Pierre Neidhardt https://ambrevar.xyz/ [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --]
Hello, Dnia 2020-07-11, o godz. 14:49:58 Pierre Neidhardt <mail@ambrevar.xyz> napisał(a): > In this case the common procedure is to add a (non-public) > opendht-jami package at the right commit. > > This package can then safely be deleted when the next version of > opendht comes out. > > Cheers! > I made a patch already. https://lists.gnu.org/archive/html/guix-patches/2020-07/msg00283.html It seems opendht is just buggy there, as using one of its features causes compilation error, so I think it is okay to patch the bug. What's the point of keeping unusable software in the repo anyway? Devs from Savoir-faire linux use opendht features in Jami right from master, because they develop both. But I can't do that. Jan Wielkiewicz
[-- Attachment #1: Type: text/plain, Size: 738 bytes --] Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes: > I made a patch already. > https://lists.gnu.org/archive/html/guix-patches/2020-07/msg00283.html > It seems opendht is just buggy there, as using one of its features > causes compilation error, so I think it is okay to patch the bug. > What's the point of keeping unusable software in the repo anyway? > Devs from Savoir-faire linux use opendht features in Jami right from > master, because they develop both. But I can't do that. If you have a legitimate reason to think that current stable is unusable, feel free to update the opendht public package to the commit that works and add a comment explaining why. -- Pierre Neidhardt https://ambrevar.xyz/ [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --]