From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2BGHKjDTwF8kLwAA0tVLHw (envelope-from ) for ; Fri, 27 Nov 2020 10:21:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6CRPJjDTwF8XZwAA1q6Kng (envelope-from ) for ; Fri, 27 Nov 2020 10:21:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DA6A9401BF for ; Fri, 27 Nov 2020 10:21:36 +0000 (UTC) Received: from localhost ([::1]:52188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiash-0001JI-0N for larch@yhetil.org; Fri, 27 Nov 2020 05:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiasD-0001Ho-9Y for guix-devel@gnu.org; Fri, 27 Nov 2020 05:21:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36702) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiasB-0007zL-I9 for guix-devel@gnu.org; Fri, 27 Nov 2020 05:21:04 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46730 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kias9-0003Qs-0a; Fri, 27 Nov 2020 05:21:02 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: 01/03: guix: store: Add ensure-path. References: <20201122161938.30063.63195@vcs0.savannah.gnu.org> <20201122161940.6485520981@vcs0.savannah.gnu.org> <87mtz9knjl.fsf@gnu.org> <87tutgwi7h.fsf@gnu.org> <87o8jojoh7.fsf@gnu.org> <87o8jow6u5.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 27 Nov 2020 11:20:59 +0100 In-Reply-To: <87o8jow6u5.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 23 Nov 2020 14:17:22 +0100") Message-ID: <87wny7umlw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.76 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-TUID: eKGrqAnYnMqr Hi, Mathieu Othacehe skribis: >> Yeah, =E2=80=98guix offload=E2=80=99 should not connect to the daemon. = It does so >> currently for one thing (registering GC roots IIRC), which should be >> done in Scheme instead. > > Why shouldn't it connect to the daemon? In the current implementation of > the nix daemon, there's the following snippet: > > if (!missing.empty()) { > Activity act(*logger, lvlTalkative, actUnknown, fmt("copying = outputs from '%s'", storeUri)); > for (auto & i : missing) > store->locksHeld.insert(store->printStorePath(i)); /* FIX= ME: ugly */ > copyPaths(ref(sshStore), store, missing, NoRepair, NoC= heckSigs, NoSubstitute); > } > > in build-remote.cc. So it looks like it connects to the store, add the > outputs to locks held and import them, which is the behaviour I'm > trying to replicate. Yes but here =E2=80=98store=E2=80=99 is an instance of =E2=80=98LocalStore= =E2=80=99 typically. I=E2=80=99m referring to this bit in (guix nar): (with-store store (let loop ((name (temporary-store-file))) ;; Add NAME to the current process' roots. (Opening this connection = to ;; the daemon allows us to reuse its code that deals with the ;; per-process roots file.) (add-temp-root store name) This is (I think) the only place where =E2=80=98guix offload=E2=80=99 conne= cts to the daemon, and it does so just because we don=E2=80=99t have an =E2=80=98add-t= emp-root=E2=80=99 implementation in Scheme. >> Specifically it handles =E2=80=9Cnar bundles=E2=80=9D (new name :-)). B= ut probably you >> can extract the relevant bits to import single nars, right? > > Yup you're right, it should be possible, but I'd rater let the daemon do > it if possible. Sure, but see =E2=80=98restore-one-item=E2=80=99 vs =E2=80=98restore-file-s= et=E2=80=99. Perhaps =E2=80=98restore-one-item=E2=80=99 already does what you want. HTH, Ludo=E2=80=99.