From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ET3AISA8LGDBYwAA0tVLHw (envelope-from ) for ; Tue, 16 Feb 2021 21:41:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id RgsMHSA8LGDCXQAA1q6Kng (envelope-from ) for ; Tue, 16 Feb 2021 21:41:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1084610434 for ; Tue, 16 Feb 2021 22:41:52 +0100 (CET) Received: from localhost ([::1]:46282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC86R-0004wj-69 for larch@yhetil.org; Tue, 16 Feb 2021 16:41:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC86E-0004vB-3Z for guix-devel@gnu.org; Tue, 16 Feb 2021 16:41:38 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]:47792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC86B-0005y5-H0 for guix-devel@gnu.org; Tue, 16 Feb 2021 16:41:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=JjDs32VyQIK2d+52pnN6Kce1qajTP25enxXMgNmFvuo=; h=date:in-reply-to: references:subject:cc:to:from; b=hmJ204QJx1MLBnISrqiiY4/1XjaTIR8EfXDuI s26uBvhUJOvS1mNahlNy0Xf/K1+PDJZYz4oUXW6Ncz8Wkunj4ARJMBYGhHKDRfaE2eUVRf 8PekJqf+e6tBMMhnOfLmH+x//2HFpg62OAjSXjT4Rn2j9ltpNqzmd9Hn4S7Lp7oq8aBPs+ myMlXMSk1wwHvBkL+W5zEU32Mb+wztK2J2PqI8A/UuEYS4549SCUaBvwDaUvlWe/5OYhOS UcAi5HtfF2JaVJVZqfaTVqBCUgXKYm5d919nHdKwV9VCulZI8tOJcPv6nZn3il0m+GReS/ 3hD5bhLdqi2pQ4KFrtDoTerpA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a360b27f (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 16 Feb 2021 21:42:20 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Nicolas Goaziou Cc: guix-devel@gnu.org Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1. References: <87im6sxef9.fsf@nckx> <874kibhhnn.fsf@nicolasgoaziou.fr> In-reply-to: <874kibhhnn.fsf@nicolasgoaziou.fr> Date: Tue, 16 Feb 2021 22:41:39 +0100 Message-ID: <87wnv7wuzw.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=hmJ204QJ; dmarc=pass (policy=reject) header.from=tobias.gr; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 1084610434 X-Spam-Score: -4.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: R+wADzwWKGP8 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi! Nicolas Goaziou =E5=86=99=E9=81=93=EF=BC=9A > As written in the commit message, I removed it because Alacritty=20 > was > working without it Thank you. That's more than I could infer from a terse =E2=80=98Remove=20 unneeded phase=E2=80=99: you ran it on Wayland [see below] and it worked. It's OK add rationales like this above the dry changelog (I=20 mention it only because people have assumed the contrary). > here on my Gnome 3 Wayland session, hence the "unneeded" part. Are you sure Gnome 3 doesn't run X? I'd be suprised (and interested) if DISPLAY=3D $(guix time-machine --commit=3D3e10f0e -- \ build alacritty)/bin/alacritty works for you. It should complain and fail to launch at all,=20 because it can't connect to the legacy X(wayland) server. > What else was necessary? I don't know. Maybe more testing, or pinging the original author.=20 No definitive answers here. > Please bear in mind that: > 1. it was not a small version bump, so many things could have=20 > changed in > the package definition; Right, I had to bump the version numbers, but it wasn't an=20 unreasonable amount of work. > 2. the hack is actually non-trivial as it references packages=20 > that do > not even belong to the inputs but was not even a single=20 > comment line > explaining its importance. Agreed on both counts: it's a gross hack[0], and it deserves a=20 comment. I should have added one and will do so now. Kind regards, T G-R [0]: The alternative is stuffing both X libraries into=20 LD_LIBRARY_PATH, which is grosser... --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYCw8Ew0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15+kcBANRNvnvaVRdNTxF1UUAXKhPTOQ3E+mIJSwH1spQ9 NY3FAQCflBWz7MhdyoHKJ3OGyqqj6bRQwsZT22gNH2et5e6aCg== =0AIX -----END PGP SIGNATURE----- --=-=-=--