unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1.
Date: Tue, 16 Feb 2021 22:41:39 +0100	[thread overview]
Message-ID: <87wnv7wuzw.fsf@nckx> (raw)
In-Reply-To: <874kibhhnn.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]

Hi!

Nicolas Goaziou 写道:
> As written in the commit message, I removed it because Alacritty 
> was
> working without it

Thank you.  That's more than I could infer from a terse ‘Remove 
unneeded phase’: you ran it on Wayland [see below] and it worked.

It's OK add rationales like this above the dry changelog (I 
mention it only because people have assumed the contrary).

> here on my Gnome 3 Wayland session, hence the "unneeded" part.

Are you sure Gnome 3 doesn't run X?

I'd be suprised (and interested) if

  DISPLAY= $(guix time-machine --commit=3e10f0e -- \
	build alacritty)/bin/alacritty

works for you.  It should complain and fail to launch at all, 
because it can't connect to the legacy X(wayland) server.

> What else was necessary?

I don't know.  Maybe more testing, or pinging the original author. 
No definitive answers here.

> Please bear in mind that:
> 1. it was not a small version bump, so many things could have 
> changed in
>    the package definition;

Right, I had to bump the version numbers, but it wasn't an 
unreasonable amount of work.

> 2. the hack is actually non-trivial as it references packages 
> that do
>    not even belong to the inputs but was not even a single 
>    comment line
>    explaining its importance.

Agreed on both counts: it's a gross hack[0], and it deserves a 
comment.  I should have added one and will do so now.

Kind regards,

T G-R

[0]: The alternative is stuffing both X libraries into 
LD_LIBRARY_PATH, which is grosser...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-02-16 21:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
2021-02-16 15:56 ` Tobias Geerinckx-Rice
2021-02-16 20:38 ` Nicolas Goaziou
2021-02-16 21:41   ` Tobias Geerinckx-Rice [this message]
2021-02-17 10:56     ` Nicolas Goaziou
  -- strict thread matches above, loose matches on Subject: below --
2021-02-17 12:49 John Soo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnv7wuzw.fsf@nckx \
    --to=me@tobias.gr \
    --cc=guix-devel@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).