New backward incompatible version of Guile Config

New backward incompatible version of Guile Config

[Alex Sassmannshausen]

[-- Attachment #1.1: Type: text/plain, Size: 507 bytes --]

Hello,

I'm in the process of releasing guile-config 0.5, which unfortunately is
backward incompatible in some ways.

As a result I want to give developers who are using it a chance to
upgrade gradually.

To this end, in the attached patch, I add a new variable for 0.5. My
intention is to have 0.4.2 and 0.5 coexist for a while and then to
switch fully to 0.5 in due course.


Is this an acceptable way of doing a gradual transition to a backwards
incompatible version of the library?

Best wishes,

Alex


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-guile-config-0.5.patch --]
[-- Type: text/x-diff, Size: 1251 bytes --]

From fadba5c1c27d96b8e49dcf987eb3c09a2bbb0776 Mon Sep 17 00:00:00 2001
From: Alex Sassmannshausen <alex@komputilo.eu>
Date: Wed, 17 Feb 2021 16:48:39 +0100
Subject: [PATCH] gnu: Add guile-config-0.5.

* gnu/packages/guile-xyz.scm (guile-config-0.5): New variable.
---
 gnu/packages/guile-xyz.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 984c2b1109..b62dbe20d5 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1582,6 +1582,21 @@ above command-line parameters.")
 (define-public guile3.0-config
   (deprecated-package "guile3.0-config" guile-config))
 
+(define-public guile-config-0.5
+  (package
+    (inherit guile-config)
+    (name "guile-config-0.5")
+    (version "0.5.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/a-sassmannshausen/guile-config")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256 (base32
+                "1xrl8bdcvvvbsrms0s3pp3d698541fv5b5kyy1z2kwli7akvdiph"))))))
+
 (define-public guile-hall
   (package
     (name "guile-hall")
-- 
2.28.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 272 bytes --]

Re: New backward incompatible version of Guile Config

[Ludovic Courtès]

Hi Alex!

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> To this end, in the attached patch, I add a new variable for 0.5. My
> intention is to have 0.4.2 and 0.5 coexist for a while and then to
> switch fully to 0.5 in due course.
>
>
> Is this an acceptable way of doing a gradual transition to a backwards
> incompatible version of the library?

Definitely!  We’ve done that in the past for Guile-JSON, among others.

Should we commit it on your behalf?

Thanks,
Ludo’.

Re: New backward incompatible version of Guile Config

[Alex Sassmannshausen]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Hi Ludo,

Hope you're good :-)

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Alex!
>
> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:
>
>> To this end, in the attached patch, I add a new variable for 0.5. My
>> intention is to have 0.4.2 and 0.5 coexist for a while and then to
>> switch fully to 0.5 in due course.
>>
>>
>> Is this an acceptable way of doing a gradual transition to a backwards
>> incompatible version of the library?
>
> Definitely!  We’ve done that in the past for Guile-JSON, among others.
>
> Should we commit it on your behalf?

Yes indeed, please go ahead! Cheers :)

Alex

>
> Thanks,
> Ludo’.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 272 bytes --]

Re: New backward incompatible version of Guile Config

[Ludovic Courtès]

Hi again,

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> From fadba5c1c27d96b8e49dcf987eb3c09a2bbb0776 Mon Sep 17 00:00:00 2001
> From: Alex Sassmannshausen <alex@komputilo.eu>
> Date: Wed, 17 Feb 2021 16:48:39 +0100
> Subject: [PATCH] gnu: Add guile-config-0.5.
>
> * gnu/packages/guile-xyz.scm (guile-config-0.5): New variable.

[...]

> +(define-public guile-config-0.5
> +  (package
> +    (inherit guile-config)
> +    (name "guile-config-0.5")

You can remove the ‘name’ here; users will then be able to type
guile-config@0.5 when they want this version.

There seems to be something wrong with the repo though:

--8<---------------cut here---------------start------------->8---
building /gnu/store/p1shd9qg4b1v4g38kgb5m67hpi4qax82-guile-config-0.5.0-checkout.drv...
guile: warning: failed to install locale
environment variable `PATH' set to `/gnu/store/378zjf2kgajcfd7mfr98jn5xyc5wa3qv-gzip-1.10/bin:/gnu/store/sf3rbvb6iqcphgm1afbplcs72hsywg25-tar-1.32/bin'
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint:   git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint:   git branch -m <name>
Initialized empty Git repository in /gnu/store/rwijbwimw9wmps3pvxhynkq64pz47qxh-guile-config-0.5.0-checkout/.git/
fatal: unable to access 'https://gitlab.com/a-sassmannshausen/guile-config/': The requested URL returned error: 403
Failed to do a shallow fetch; retrying a full fetch...
fatal: unable to access 'https://gitlab.com/a-sassmannshausen/guile-config/': The requested URL returned error: 403
git-fetch: '/gnu/store/lhvl66fvayc77l07nkbai1j3nsgz6r52-git-minimal-2.30.0/bin/git fetch origin' failed with exit code 128
Trying content-addressed mirror at berlin.guix.gnu.org...
Trying content-addressed mirror at berlin.guix.gnu.org...
Trying to download from Software Heritage...
builder for `/gnu/store/p1shd9qg4b1v4g38kgb5m67hpi4qax82-guile-config-0.5.0-checkout.drv' failed to produce output path `/gnu/store/rwijbwimw9wmps3pvxhynkq64pz47qxh-guile-config-0.5.0-checkout'
build of /gnu/store/p1shd9qg4b1v4g38kgb5m67hpi4qax82-guile-config-0.5.0-checkout.drv failed
View build log at '/var/log/guix/drvs/p1/shd9qg4b1v4g38kgb5m67hpi4qax82-guile-config-0.5.0-checkout.drv.bz2'.
cannot build derivation `/gnu/store/ifzw7pgymllwkrv3bi51p909nkaj1d3q-guile-config-0.5.0.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/ifzw7pgymllwkrv3bi51p909nkaj1d3q-guile-config-0.5.0.drv' failed
--8<---------------cut here---------------end--------------->8---

Does the URL need an update?

Thanks,
Ludo’.