From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mFyIGR62AmK6BgAAgWs5BA (envelope-from ) for ; Tue, 08 Feb 2022 19:27:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IFE3Fh62AmKvXgAAauVa8A (envelope-from ) for ; Tue, 08 Feb 2022 19:27:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E61CC29F0A for ; Tue, 8 Feb 2022 19:27:41 +0100 (CET) Received: from localhost ([::1]:38788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHVDI-0000up-7D for larch@yhetil.org; Tue, 08 Feb 2022 13:27:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHTou-0001PJ-Os; Tue, 08 Feb 2022 11:58:26 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHToq-0007nT-LD; Tue, 08 Feb 2022 11:58:23 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1644339496; cv=none; d=zohomail.com; s=zohoarc; b=WSN1SmlV4Nq/jZbypIemMLE33jEQPtDxY8oEEIY7vnFdw16e7sq4O22Nr4LELAtLgmkPFy6BwKVqPiPQPIzDdC5obrag44gfbi1guk9xGVOMU9s6gaXPvjcS4/kPUpMH4EU9O1K/W4Ulf7a0gSgK7zkS093/R+PRac4OktEOVXs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644339496; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ikjm84DEIVWzi11ChM2va6sIS2kJi+NVLQXbLMI9e5c=; b=MoSRwfj5BsnietZcZuS//GsQiDYtTpSGMy4mV3O414SbvSh4zc1PNcupcDu2OvPdg9k1oqfFixdbs0sObZ1Gp+H06ZrkDcpASa/QynH71K48CMB8poAnXeT8M+t5GHveyWp5JWP1gJQcdPpQvBaPhnKhsKt7zHUsIBtgoyv3ceg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1644339496; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=ikjm84DEIVWzi11ChM2va6sIS2kJi+NVLQXbLMI9e5c=; b=XRxOJkbXHbg4qUP9F/FlOfit9fsmHlENyaLIB8mNj49e0DG0JHAB6gxV6gzQeYjy FvWla+aHIMk90WJ2na6LvIYMU5isFYQqKKBlTCzVulbey2fCquQ1DkfgCbXiQz3maSd DdxdGP33gnIkR29PEF8M+HB9TIvQPPuiKItEmCgg= Received: from localhost (p54ad4e3e.dip0.t-ipconnect.de [84.173.78.62]) by mx.zohomail.com with SMTPS id 1644339494243201.61106457342623; Tue, 8 Feb 2022 08:58:14 -0800 (PST) References: <878rum1pph.fsf@gmail.com> <87tud9jxc6.fsf@gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Ricardo Wurmus To: Mathieu Othacehe Subject: Re: Dropping gzip-compressed substitutes Date: Tue, 08 Feb 2022 17:53:47 +0100 In-reply-to: <87tud9jxc6.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87wni5xplp.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, guix-sysadmin , Maxim Cournoyer Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644344862; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ikjm84DEIVWzi11ChM2va6sIS2kJi+NVLQXbLMI9e5c=; b=NsLwZHOmGktxudGppDnKAz2pS2QtJaiUIezkXJaebEFVbHvXeyD1hBe0ZHGP9EWRDDlJeg LQQb4dTc+5TO1CRoMV0yqo2rNfsVbY0blyFIbo63E+1KQl+LNTN2jka7HeHWhgqxC+1nHR 9w1gAd78cL7L2u76lsGH4bJwvZkVXMqGAOMIKghLeF1RzbHsoF9Tju6O38ZXGzr9y9WCzt ukyUmI07AzEkKam6QSPAAwrbCnt/JXjBGNRvKkT6sKbufL+u6XIp5H4U6oM4SQX7JswXEm h5/qjHfgIYD2jKqRxi2oYw4sfbMFQqPVbnOGCvdr8FtAHrKchK8Ixs/AgVyuiQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644344862; a=rsa-sha256; cv=fail; b=Rtsg/9LA4EpltZHgYbzVNuemJHXk09Gmp9Qpwy4dthHw+pS/CIhkxFL1I2UWteK39KPljT Y6G4NVFo3HjvpBlvQlq9CDT3NmRim/iSp2vk9//g4iY59WbN4BpzHeaaS9cuul/paMAeYC fJGvT/MixoycEqLjVuAO5njxe7P6V3kkMSsrY6XoCEtkLjk/sk/MRW4fByjg3MffaEcycW mlZ8gE4RQO8pfs7QZUY38SrgokGGokvLj3mMgJ8vlwQ4jcqe94E1x5LWJjFwII3sLtjulV ZFu75uwqV2GLdhZr3e0mP+QKUIz8jkebjR/OWebWES9kTP++YqjGHCtNder77A== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=XRxOJkbX; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=XRxOJkbX; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E61CC29F0A X-Spam-Score: -1.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: ifFyoGFXCKF9 Hi Mathieu, thanks for the patch! > From bd306a8b20f2033d67755dd332a5d33b2f6b822d Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Tue, 8 Feb 2022 14:28:56 +0100 > Subject: [PATCH 1/1] store: Warn about daemon deprecation. > > * guix/deprecation.scm (warn-about-old-daemon): New procedure. > * guix/store.scm (build-things): Use it to warn about old daemons. > --- > guix/deprecation.scm | 7 +++++++ > guix/store.scm | 2 ++ > 2 files changed, 9 insertions(+) > > diff --git a/guix/deprecation.scm b/guix/deprecation.scm > index c66c9367f6..666e178d75 100644 > --- a/guix/deprecation.scm > +++ b/guix/deprecation.scm > @@ -1,5 +1,6 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2019, 2020, 2021 Ludovic Court=C3=A8s > +;;; Copyright =C2=A9 2021 Mathieu Othacehe > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -24,6 +25,8 @@ (define-module (guix deprecation) >=20=20 > define-deprecated/public > define-deprecated/alias > + > + warn-about-old-daemon > warn-about-deprecation)) >=20=20 > ;;; Commentary: > @@ -32,6 +35,10 @@ (define-module (guix deprecation) > ;;; > ;;; Code: >=20=20 > +(define (warn-about-old-daemon) > + (warning (G_ "Your Guix daemon is seriously outdated, please consider > + updating it by following the 'Upgrading Guix' documentation section.~%"= ))) > + s/documention section/section in the manual/ Should it also mention that staying with the old daemon means that binaries will no longer be available? For example: Your Guix daemon is no longer supported and will soon no longer be able to download binary substitutes. I realize that what you proposed is a generic warning, but perhaps it=E2=80= =99s better to mention a direct consequence of failing to upgrade. (I know many people who will not upgrade unless they absolutely have to.) > --- a/guix/store.scm > +++ b/guix/store.scm > @@ -1442,6 +1442,8 @@ (define build-things > things))) > (parameterize ((current-store-protocol-version > (store-connection-version store))) > + (when (< (current-store-protocol-version) 355) ;0x163 > + (warn-about-old-daemon)) > (if (>=3D (store-connection-minor-version store) 15) > (build store things mode) > (if (=3D mode (build-mode normal)) Maybe add a comment here to explain why this particular protocol version is considered old. --=20 Ricardo