From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id naHdMW8C/WQtigAAauVa8A:P1 (envelope-from ) for ; Sun, 10 Sep 2023 01:40:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id naHdMW8C/WQtigAAauVa8A (envelope-from ) for ; Sun, 10 Sep 2023 01:40:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7895753137 for ; Sun, 10 Sep 2023 01:40:31 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=h8KY1zEH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694302831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Qc0W/9L3rnq0AFLlgrGuIS+C0tL9kv/+rQNow4lDR6c=; b=iGRJkSuO33IC5eNbHP/TKntDTXv3HNd4aQ53m9Ozcv3bY7CAKLX6mPL/H7jOD3n/37S1X6 bSFzel110jTgRmMkST3EKeMxq+Eo/tVZP4zBtwAwxuqTHGEWH/nfS+shGqpjKpa9RatHSF 3hkEvkeuh/YxeNO8oVCuEjawDo5NDiPZr+uZnMInFRv6bOCjx1ECUWH4Cq/pGX+DTtUbas 6PhpGwypAyLdpR16X3/bFXseMzA3R0e6bhnvVPC9h7tfm/y9eoDSv8jc5SJFEBowU/3MLU a+PeGnxdY9lXbbpoUAgYXEIIRc85LU56GQ0GQ9H7dOKKzeP2Gco+oNIE7nVYng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694302831; a=rsa-sha256; cv=none; b=AUGJArTKoIN3SgQEJhvOKitCRS7p7kcJ5T21K81fUeQPyeBV4fyaEjC5bzbysviyDmsCrK Rs76mmsMX0jV9M6KW+LxDqXx2bXF6dSbeE1KQZSknnNG+DnzSIKZiO/K84UkltrDl+rU6j chhZmQvUQf5I0oLrdKh8493FdQIAho73O1nME/7Gx/s3CS3mr5BawE77N//ptoVQ3qleYL qrY2cAoNMauTUqzrTKPZOMwYlpVnj6loq5/SeJgCEeRHF6QAACRf2iVEAtyJ9HZRiJFvw4 bxIol79CtSjF6XeBON1u0XQcKt68bu7+GpDBtgX/miV7+0XRPwdtQi7rDJfCCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=h8KY1zEH; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qf7Ya-0004Qm-Qx; Sat, 09 Sep 2023 19:40:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qf7YZ-0004Qc-Bz for guix-devel@gnu.org; Sat, 09 Sep 2023 19:40:03 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qf7YV-0001FU-QJ for guix-devel@gnu.org; Sat, 09 Sep 2023 19:40:01 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-6556d05a55fso17927206d6.3 for ; Sat, 09 Sep 2023 16:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694302798; x=1694907598; darn=gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qc0W/9L3rnq0AFLlgrGuIS+C0tL9kv/+rQNow4lDR6c=; b=h8KY1zEHODNAIfDCdbl7FRjKvhDHS0kNCvAliGD86MOOwhYeji/DcTzXJCxLLbFLx1 4dNOYG7V6Yq7xF1fd2xVYK+31z9rirezNTXSy4Fo+aSIwzSxRJSo+RkuyfE9INxLTFu/ TtXeNDemZOlQ4swWBYuPFulsVKXZjjVVNwVNx6CF+3bZa2C0Qgnx1GPQeMK0sZ75x4WR v8Re1xT3eLVqlJEG2fFlLFRhomTqQXBMyhaSkPwwV4kNYAyVjWTcJ9sRU/+kVj7xcr09 SMsw9WzKwuijXrHS2SX4nYZyYN+XlYYYuUDmUTlhiUS26PY0KWSi64ksetRM5mbq44VF FAVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694302798; x=1694907598; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qc0W/9L3rnq0AFLlgrGuIS+C0tL9kv/+rQNow4lDR6c=; b=Gwaz+3p/ShNOOtgEZKIesn13WALxhAjBhb0ya/OarFAskmGYQIPnV/p2XLObXbhCfj C7rcWH0lwcyWLWOh91/ZtGzcRr825/jwHvwLz2bjIIo6OgRZwvnba4igcpE8MgWasqOG yQFS5DDX7RTwdib5xLxzsVCSDYb/8cufiNwF+jMOAHOreJS2MVDPeU6kx/DNsDn8KxnE SL1mFKKQn8nhkDkcgqEY5UAUjlwlI7VQ1zTUIqrHRB9lKivgJereMcUh4SpjCO6Irxrf ARLudinxlHQqejwX2ytdawzIzK7v2iue8FkLgzR1rBJqiC/efMdIym8oXjnOheUyzaNK mrNg== X-Gm-Message-State: AOJu0Yzm4A+jztnZvMsyiZfBoHFA1j9O5IaLhiDLEGkIhkuxegw6Rkh1 rokGTCjzUtsah61dJqKtBV6YcGAHJWo= X-Google-Smtp-Source: AGHT+IH4dxckmmaHP2IlaYOdNJo45bo9ARwiopsy1Qd1vbLnssTN7EkREyq/qZWTuT3Niet+ll3lYQ== X-Received: by 2002:a05:620a:4095:b0:76f:1eac:e720 with SMTP id f21-20020a05620a409500b0076f1eace720mr7332699qko.25.1694302798549; Sat, 09 Sep 2023 16:39:58 -0700 (PDT) Received: from hurd (dsl-155-89.b2b2c.ca. [66.158.155.89]) by smtp.gmail.com with ESMTPSA id d1-20020a05620a166100b0076db5b792basm1542069qko.75.2023.09.09.16.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 16:39:57 -0700 (PDT) From: Maxim Cournoyer To: Giovanni Biscuolo Cc: Simon Tournier , guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <86o7ien856.fsf@gmail.com> <87wmx2oi5s.fsf@gmail.com> <87edjaf7qa.fsf@xelera.eu> Date: Sat, 09 Sep 2023 19:39:56 -0400 In-Reply-To: <87edjaf7qa.fsf@xelera.eu> (Giovanni Biscuolo's message of "Thu, 07 Sep 2023 15:11:57 +0200") Message-ID: <87wmwyx6er.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2d; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -9.57 X-Migadu-Queue-Id: 7895753137 X-Migadu-Spam-Score: -9.57 X-TUID: ZmGpOPxNTawr Hi Giovanni, Giovanni Biscuolo writes: [...] >> We could use Gerrit's commit hook that adds a unique ID as a git >> trailer. > > Do you mean "commit-msg" hook as documented here: > https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html > ? > > > The Gerrit Code Review supplied implementation of this hook is a short shell script which automatically inserts a globally unique Change-Id tag in the footer of a commit message. When present, Gerrit uses this tag to track commits across cherry-picks and rebases. > >> Then it should become possible to >> >> 1. Check if all items of a series have appeared in the git history >> 2. If so, close the associated issue if it was still open > > Thinking out loud: > > a. each contributed patch will have a unique Change-Id, persistent > across rebases (and git commit --amend), and every new patch version > (produced during patch revision) will have the same Change-Id; this is > valid for all commits in a patch set Correct. > b. when all "Change-Id"s of patches contained in a patch set are listed > in the git history (of one of the official branches) the associated > issue can be closed That was my idea. > c. how do we get the issue number of a patch containing "Change-Id"? [1] We'd have to search through the currently opened patches issues; I assume using a tool like the 'mumi' command we already have could do that. > [1] right now how do we get the issue number of a committed patch? There's no direct mapping. You have to search by subject name. -- Thanks, Maxim