From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6KxWKMJhBmUwNAEAG6o9tA:P1 (envelope-from ) for ; Sun, 17 Sep 2023 04:17:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6KxWKMJhBmUwNAEAG6o9tA (envelope-from ) for ; Sun, 17 Sep 2023 04:17:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A34756DFF for ; Sun, 17 Sep 2023 04:17:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W0YX6lne; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694917058; a=rsa-sha256; cv=none; b=Lgf2yd7MvM2jt5rfOjc4PpWIMCHNOIAGyeq6E81KakiVYJL2NMF7ggwC3RxQ02UcYD3QSp V2kfOZbis+yR1T8oL8adjGBaF0njZzVcy+xawjSphw2CdW4Pq2AKH5jNLCQVoLTP/WpzIw 0Iqh4QFPNEQjbaVdz6XprBLP7M180uWwWlY3lP/1oTefGEMMTGU3jalGGLnzkHRtOGf8d9 iAZSCmB6fOp6suiXy1pdZ+J47oQ9sHihijR/elcQNoqMl8kWfFF4QNQDD6mt2M9dvSQqz1 WLRzA0j5bhFDwmP5ye7Bfg4D/67qyR0lMi7pbEXVhm3KaKOhhfFjJ3YZ0EO9xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694917058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=o7NM8hOquEDbtmgyvDiJ3cIgVdWydSiNPX5KWr+O4g8=; b=LMx1Wbr83Vsyv7vXbSeJcTSIp17aE+mHnDoFuDT/CMEbJYJ/0B0MBX8NqPhufUnEhpz4Tu wuG2DdMySD84eqyyZXr+S2fK8pXItmcJs/Xpt6DMDGOgW5tClWE5jeymBHpDw0LwxZisK1 fQRX5FO113QJJHVRvM79aZxeAM1JN/jO1iL13IUnvfgqTd1e/Oqv5r55k7A6bVEBvX/kfx o826tDe0/6t52x4q/piMbUjhlFWApZiEaMrNnPAd+N6r/14ydnIIPbTTstvbb3Y0yiiTaE dpvFeU0DDPqgVImJHwWjAnjcaQFXUjsannzcyI/qpdk5Jzu/SdaMIGThaMFEJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W0YX6lne; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhhLB-0001u4-5U; Sat, 16 Sep 2023 22:16:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhhL8-0001sT-DE for guix-devel@gnu.org; Sat, 16 Sep 2023 22:16:51 -0400 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhhL5-0006oO-5g; Sat, 16 Sep 2023 22:16:48 -0400 Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-6564fe1967dso1860776d6.1; Sat, 16 Sep 2023 19:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694917004; x=1695521804; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=o7NM8hOquEDbtmgyvDiJ3cIgVdWydSiNPX5KWr+O4g8=; b=W0YX6lnehBKyFQdrFvKjSJjpY285RxbpkI6PFryrBb5NF/SEN0e7cD3FQzTy5bh+i7 /GIk7/RLSMnci4prEACJwN6nTl3pfQMwlIiuXepFKGsSE0K6bP+523ELbKwpsyZEbBH+ 2jonyjgRCquOlf850tkA72Kb1HPDzeOIsMaIgsiCdVndW0L1CMNdjebk4IROWN6L+Luv cOl2bY9U2EKZwPvoFXpEdX8O1aBm47giCrdJrZSsGmU8aEmLyJLsrP/8YOr2eo2SgjPX cS/kQ9kNbZ0kBYyi6/8r+8TzU2raXTjuAqPJr+f1hxi9NuC/CSTzRroVKZhYtkh3Fbar 4QQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694917004; x=1695521804; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o7NM8hOquEDbtmgyvDiJ3cIgVdWydSiNPX5KWr+O4g8=; b=meQ6ox6dWw8UHcc5LdURO5OtO4mp3DQECCuKzHeRs1ay5/EmYQYeu2+InrcJYkwMoI ad7ySNuSAM7PpkC02LiQcQzPvyYad+wRQMa7IzL9rutyRqkuykNqIOlimriQL8AZvLzJ gRuzBsVkJVXtxQplZEjcB008eHgErAQgUGE5/DHWCJflP3fAmSIX6bvTAofHfTiB//dR MgXLwrv1xHX7K9M8LVnXlU6nWQz9eBFpHdNlAFZ0CawdNlyxPKuquK+5hAQ6l3qktvWn lReyTSaktCeFduQf0HwLCTF/iKvSl17tdGFtRisNwjqA1NAw2pdfWv3C5TZ/Iux6gZJG jY9A== X-Gm-Message-State: AOJu0YySmEcEsR2f2FnwgXeAUQLPLza1ZM1PNUqZVnLVMWHOF504cpac frnlY2JNyYO2Atj4U+NAZCU= X-Google-Smtp-Source: AGHT+IFpTBEqPy2BoLy5ukdf/st4thXbQNhTcDDXwdAgDnCsn9Z9pfyso9jEUmTbRRl/MKRuccBnhA== X-Received: by 2002:ad4:5b8b:0:b0:63f:9130:4e9c with SMTP id 11-20020ad45b8b000000b0063f91304e9cmr9341063qvp.26.1694917003899; Sat, 16 Sep 2023 19:16:43 -0700 (PDT) Received: from hurd (dsl-10-149-131.b2b2c.ca. [72.10.149.131]) by smtp.gmail.com with ESMTPSA id r1-20020a0c9e81000000b00653589babcbsm1621482qvd.87.2023.09.16.19.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 19:16:43 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Simon Tournier , guix-devel@gnu.org, 65866@debbugs.gnu.org Subject: Re: hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) References: <871qf4ivsr.fsf@gmail.com> <87r0n4wp0d.fsf@gmail.com> <878r987l5t.fsf@gnu.org> Date: Sat, 16 Sep 2023 22:16:41 -0400 In-Reply-To: <878r987l5t.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 14 Sep 2023 18:51:42 +0200") Message-ID: <87wmwp8rxy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.95 X-Spam-Score: -7.95 X-Migadu-Queue-Id: 4A34756DFF X-Migadu-Scanner: mx2.migadu.com X-TUID: 8lqtm7wYOcBM Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi! > > Maxim Cournoyer skribis: > >> So given there's no technical reasons not to use libgit2, I'd use that >> and keep the closure size down. > > For the record, that=E2=80=99s a 6% increase: > > $ guix size guix | tail -1 > total: 633.0 MiB > $ guix size guix git-minimal | tail -1 > total: 675.7 MiB > > (Of course it all adds up; I=E2=80=99m not saying we can dismiss it.) As Simon pointed out, it'd be more after wrapping 'git' with coreutils and possible util-linux on its PATH. > In the context of plus the lack of > GC in libgit2 discussed in , my > inclination is to include that hard dependency on Git. > > That=E2=80=99s not a happy choice for me, but it has the advantage of sol= ving > two immediate problems. > > I would revisit it as soon as libgit2 supports shallow clones (which is > coming, as you write) This isn't "coming", it's already been released :-). > and GC (or a workaround to that effect). SHA256 may also soon be a > requirement: we=E2=80=99ll need to be able to clone repos that use it. > > How does that sound? Yeah, 'git gc' is lacking from libgit2. I'm not against adding dependency on the real 'git' CLI, but at that point, as Simon mentioned, I see little reason to keep libgit2 around for much longer, given it performs worst than git CLI in every aspect. I doubt forking processes on GNU/Linux would cause a performance hit compared to using libgit2, especially given how optimized git appears to be (at least compared to libgit2). So, I think we need to agree on the future of libgit2 in the big picture and decide to invest in it or let it in favor of just using git. --=20 Thanks, Maxim