From: Bruno Victal <mirai@makinata.eu>
To: guix-devel@gnu.org
Subject: Expressing system test dependencies
Date: Thu, 26 Oct 2023 15:41:30 +0100 [thread overview]
Message-ID: <87wmv9igyt.fsf@makinata.eu> (raw)
Hi,
There are system tests that would benefit from being able to express
that their results are dependent on the result of other tests, when
these constitute independent units, especially when there are
configuration variants present. (e.g. gnu/tests/gdm.scm)
Consider the following files/system-tests [1]:
* gnu/tests/gdm.scm
Right now this module implements two tests: %test-gdm-x11 and
%test-gdm-wayland. (whose names are self-explanatory)
* gnu/tests/vnc.scm
This module implements one test, %test-xvnc, in particular it does so
by testing the XDMCP feature using GDM.
Note: this module predates gnu/tests/gdm.scm.
Here's where we would benefit from being able to express system-test
dependencies. Clearly some of the “test-assert” clauses in
gnu/tests/vnc.scm would be better placed in gnu/tests/gdm.scm as they
are GDM specific tests. Since they constitute configuration variants of
the service, it would be placed into a %test-gdm-autosuspend variable.
The rationale for a test-dependency mechanism is as follows:
Suppose we split the GDM specific test to (gnu tests gdm). Now let's say
that we run %test-xvnc and it fails. Is the failure due to GDM or is it
caused by something else? (within the %test-xvnc)
By splitting the test to (gnu tests gdm) we would have to run the GDM
tests first, which isn't obvious. If we could express a dependency here,
the debugging experience is improved as we now have a way to know that a
integral component involved in the test failed. (or could be used to
rule out other parts)
Since the system-test results are expressed as derivations, successful
tests shouldn't result in duplicate runs so perhaps we could make use of
this fact for the effect?
[1]: guix: 33f5b747b4a0a508e1ffc94a5bf425cff707c6e3
--
Thanks,
Bruno.
next reply other threads:[~2023-10-26 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 14:41 Bruno Victal [this message]
2023-10-31 20:20 ` Expressing system test dependencies Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmv9igyt.fsf@makinata.eu \
--to=mirai@makinata.eu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).