unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: guix-devel@gnu.org
Subject: QA is back, who wants to review patches?
Date: Fri, 09 Feb 2024 10:44:11 +0000	[thread overview]
Message-ID: <87wmrddheu.fsf@cbaines.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hey!

After substitute availability taking a bit of a dive recently, the
bordeaux build farm has finally caught back up and QA is back submitting
builds for packages changed by patches.

QA also has a feature to allow easily tagging patches (issues) as having
been reviewed and ready to merge (reviewed-looks-good). You can do this
via sending an email and QA has a form ("Mark patches as reviewed") on
the page for each issue to help you do this.

I'd encourage anyone and everyone to review patches, there's no burden
on you to spot every problem and you don't need any special
knowledge. You just need to not be involved (so you can't review your
own patches) and take a good look at the changes, mentioning any
questions that you have or problems that you spot. If you think the
changes look good to be merged, you can tag the issue accordingly.

When issues are tagged as reviewed-looks-good, QA will display them in
dark green at the top of the list of patches, so it's on those with
commit access to prioritise looking at these issues and merging the
patches if indeed they are ready.

Let me know if you have any comments or questions!

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

             reply	other threads:[~2024-02-09 11:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 10:44 Christopher Baines [this message]
2024-02-09 12:43 ` QA is back, who wants to review patches? Clément Lassieur
2024-02-09 13:31 ` Tanguy LE CARROUR
2024-02-09 13:44   ` Christopher Baines
2024-02-09 13:53     ` Tanguy LE CARROUR
2024-02-09 14:30       ` Andreas Enge
2024-02-09 15:08         ` Tanguy LE CARROUR
2024-02-11  8:01           ` Andreas Enge
2024-02-09 15:04 ` Andreas Enge
2024-02-09 15:57   ` Christopher Baines
2024-02-10  8:28 ` Vivien Kraus
2024-02-10  9:42   ` Christopher Baines
2024-02-10  8:40 ` Vivien Kraus
2024-02-10  9:43   ` Christopher Baines
2024-02-12  0:21 ` Ian Eure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmrddheu.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).