From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id aJypC8OHPmagRwAAqHPOHw:P1 (envelope-from ) for ; Fri, 10 May 2024 22:46:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id aJypC8OHPmagRwAAqHPOHw (envelope-from ) for ; Fri, 10 May 2024 22:46:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=A8+sBwbe; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=2; s=key1; d=yhetil.org; t=1715374019; a=rsa-sha256; cv=pass; b=e6HtEDHMssC91uwkkIJltAiSIEFp2zhqo+FZARquL8ELHoyxxB8kCl1DQAJVEdqGHV0tRd +xYIKGCVxfCaAEg8zHaIOSSlbYtqznqsEWpiGzS6HF5rPJksZTqX1HQOocFeuZZ9BMlcvJ kut2ad2HNd/rm6BZAlLKVC+sE9JI4G4lfgFQqUs2Gd1d2Qid6/P1vKsAAd4fKuadlWheUB Z8NlBQn45n405tC9p5a5hK3sR84tamYeuopSbSixvPKn/D8+Pp2DANj4dht0gnTiWIVdIr JfLFNssL3TUGrHQR/3m63i1fups9oaI1E+KRMMPvDXR7c7F+N7bRwUwVqkTkAg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=A8+sBwbe; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715374019; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kmSrfhM7d5JB5YQ+TvVV8TAuUEYApzjorkssPulqqe8=; b=EF4/usoK9tI9iQf84WCRLswNyQrllMQs27RKupUvxKR20/eSk1ItxSiyUq7OI4OUCQL4OG Zp0pkgf76NBsRRzOfO8xTzLN9UccwbYh7StdpJBpndhSn62KDU4kKneRu+zbtnEKxravcj ARhFCSARGM6LjKtUTN+JFe0H/eGA2W1US23iyw1hZxaUcExFJONocVx+0pcVfMzpD7YD4i bMDFvpOX2QSr+TR6F/3tNKl2D9yvCIsvhaquHEViAu5SCUVuuBK3LqE6GOBJW0Ns4BoLcr lNjLis3V7ZmGtQRMRwQ6qW2Sb+kbeGjg8IDUgf/739Rd1brirRwHy4v++D8JIQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51A9512791 for ; Fri, 10 May 2024 22:46:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5X8M-0007lD-9O; Fri, 10 May 2024 16:46:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5X8K-0007l1-Md for guix-devel@gnu.org; Fri, 10 May 2024 16:46:24 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5X8D-000261-EX for guix-devel@gnu.org; Fri, 10 May 2024 16:46:24 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1715373972; cv=none; d=zohomail.com; s=zohoarc; b=JTqivChcUaK/UHDon1UdA5FrEUDSrPwqNqqZ/vakY9MwaolDAYYbhCmwMSNz0o4uatZlxzzLmU3KigPZubeb3fJdKfNPe8O0TRlkvff0A4h7kkGM+UaDjoyJFGvZ/4CcgG2U9SAeCbaPgXRdK8iYILi+e4FIvhrDnK/QNCSzWds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715373972; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=kmSrfhM7d5JB5YQ+TvVV8TAuUEYApzjorkssPulqqe8=; b=ZTdBsLN+l292yTDqkh9VoEuPFfkc2dghALO8OL9hbsOfyGQwGRCkP2zzHxFYzmbz/VZGJ2wXsQnu0KjJVr9xVjlBbpneOURrr6K0rbj3NTGCjZYgPsW3PjicoH3h+t+nPSXYZ34hE5pUjo5AYbyPUw7rnzpFwihWiQVACkUxRro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1715373972; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=kmSrfhM7d5JB5YQ+TvVV8TAuUEYApzjorkssPulqqe8=; b=A8+sBwbelfjMaqfqt6iOJb9p6kO7cGfowGXNUea50ipHH+Lm7cJJFJ7Wx3yuLDav jDfiwqOK0xsb/Gk/W1vrCmCRrnjiF5q55FWjoKzvABrx+4Y4npiodO0VVWP4nuX9vj4 PE/r1A1nceBzxj6sIm0EvHzBvlD7cE6vuhZ/Aw7k= Received: by mx.zohomail.com with SMTPS id 1715373970870899.8965982539593; Fri, 10 May 2024 13:46:10 -0700 (PDT) From: Ricardo Wurmus To: kiasoc5 Cc: Christopher Baines , guix-devel@gnu.org Subject: Re: branch master updated (2bea3f2562 -> 6745d692d4) In-Reply-To: (kiasoc5@disroot.org's message of "Fri, 10 May 2024 11:28:48 -0400") References: <171516621153.22775.5117245167398918147@vcs2.savannah.gnu.org> <875xvnfi17.fsf@cbaines.net> <87fruqrafi.fsf@elephly.net> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Fri, 10 May 2024 22:46:06 +0200 Message-ID: <87wmo1pf8x.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 51A9512791 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.47 X-Spam-Score: -8.47 X-TUID: yxT0Z4w/itOz kiasoc5 writes: >>> Also, there appears to be a couple of FIXUP commits that were pushed. >> Yeah, it's very annoying that I missed these two FIXUP commits :-/ >> > > Seeing that these are the only 2 FIXUP commits on the master branch > history so far, would it make sense to force push and edit the > history? Yes, it would mess up everyone's local checkout, but if > editing the history for Guix would ever be justified, I feel like this > would be one such scenario. I don't see how one would consider something as drastic as rewriting history justified in this case. The commits are not bad. They are not wrong. The opposite is the case: they fix mistakes introduced by previous commits. They only have the wrong commit message, and they only have the wrong message because they are so small that I had planned to meld them with the then unpublished commits that introduced the bugs. Rewriting history would be a colossal overreaction. Instead these commits should be a visible reminder that even contributors of many thousand commits over the past decade may still fumble the ball and mess up. (Alas, this is not a reminder I personally need...) -- Ricardo