From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Generation 0
Date: Wed, 25 Sep 2013 14:50:08 +0200
Message-ID: <87vc1pnjzz.fsf@gnu.org>
References: <87vc2o4qwc.fsf@gnu.org> <87y57kljro.fsf@karetnikov.org>
	<87hae81uvo.fsf@gnu.org> <87li2oslzh.fsf_-_@karetnikov.org>
	<87hadcr4sh.fsf_-_@karetnikov.org> <8738ow5zif.fsf@gnu.org>
	<87vc1r6nu0.fsf@karetnikov.org> <87eh8ebdba.fsf@gnu.org>
	<871u4d97ku.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VOoch-00016P-Fk
	for guix-devel@gnu.org; Wed, 25 Sep 2013 08:55:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VOocb-0007kL-O5
	for guix-devel@gnu.org; Wed, 25 Sep 2013 08:55:19 -0400
Received: from hera.aquilenet.fr ([141.255.128.1]:59758)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VOocb-0007k5-Hj
	for guix-devel@gnu.org; Wed, 25 Sep 2013 08:55:13 -0400
In-Reply-To: <871u4d97ku.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Wed, 25 Sep 2013 02:29:53 +0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: guix-devel@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> What about these patches?  Should the first patch also test the
> following case?
>
> +                (let ((numbers (generation-numbers profile)))
> +                  (if (equal? numbers '(0))
> +                      (exit 1)
> +                      (for-each list-generation numbers))))

The first patch below already contains that snippet, so I=E2=80=99m not sure
what you mean.

> From f42056aa768a405a893b5846dad8f8fa576b1156 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <nikita@karetnikov.org>
> Date: Tue, 24 Sep 2013 22:11:16 +0000
> Subject: [PATCH 1/2] guix package: Exit with 1 when a generation cannot be
>  listed.
>
> * guix/scripts/package.scm (guix-package)[process-query]: Exit with 1
>   when a generation does not exist or the profile points to the zeroth
>   generation.
> * tests/guix-package.sh: Test the former case.

OK, please push.

> From bea0168c28932921e6e2d6dcf3e9a26c555b698c Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <nikita@karetnikov.org>
> Date: Tue, 24 Sep 2013 22:18:09 +0000
> Subject: [PATCH 2/2] guix package: Do not list the zeroth generation.
>
> * guix/scripts/package.scm (guix-package)[process-query]: Change
>   'list-generation' to not list the zeroth generation.
> * tests/guix-package.sh: Test it.
> * doc/guix.texi (Invoking guix package): Document it, and use the
>   right term when talking about generations.

OK, push as well.

Thanks,
Ludo=E2=80=99.