From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu : add GNU Mig
Date: Tue, 18 Feb 2014 18:05:41 +0100
Message-ID: <87vbwc8i6y.fsf@gnu.org>
References: <CAFtzXzOhCjvHGHDBnTQCoWJJyepp2hOuL-OyCr6ZuOAu5eFJZA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WFo7E-0006ht-G9
	for Guix-devel@gnu.org; Tue, 18 Feb 2014 12:06:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WFo76-0003mC-2W
	for Guix-devel@gnu.org; Tue, 18 Feb 2014 12:05:52 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:53108)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WFo75-0003lz-Q6
	for Guix-devel@gnu.org; Tue, 18 Feb 2014 12:05:43 -0500
In-Reply-To: <CAFtzXzOhCjvHGHDBnTQCoWJJyepp2hOuL-OyCr6ZuOAu5eFJZA@mail.gmail.com>
	(Manolis Ragkousis's message of "Tue, 18 Feb 2014 16:10:23 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> My second patch for adding GNU Mig. :-D

Nice!  A couple of comments:

> +(define-public gnumig
> +  (package
> +    (name "gnumig")

The variable and package name should be =E2=80=98mig=E2=80=99 (=E2=80=98gnu=
mach=E2=80=99 is one of the
exceptions to the rule.)

> +    (arguments
> +    `(#:configure-flags '("TARGET_CPPFLAGS=3D-I /include" "--build=3Di68=
6-pc-gnu")

Note that the backtick should be aligned with the =E2=80=98a=E2=80=99 of =
=E2=80=98arguments=E2=80=99.
If you use Emacs, pass the expression through M-x indent-region.

> +      #:phases (alist-delete
> +                'build
> +                %standard-phases)

What does it do if it doesn=E2=80=99t build anything?  :-)
That seems wrong to me.

> +    (synopsis "GNU MIG, the Mach interface generator")
> +    (description
> +     "GNU MIG is the GNU distribution of the Mach 3.0 interface generato=
r MIG, as maintained by the GNU Hurd developers for the GNU project.
> +You need this tool to compile the GNU Mach and GNU Hurd distributions, a=
nd to compile the GNU C library for the Hurd. Also, you will need it
> +for other software in the GNU system that uses Mach-based inter-process =
communication.")

Please wrap lines to ~75 characters.

Also, for GNU software, we use the =E2=80=9Cofficial=E2=80=9D synopsis and =
description.
You can run =E2=80=98make sync-descriptions=E2=80=99 to obtain the right fo=
r MiG.

Thanks,
Ludo=E2=80=99.