unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 1/4] gnu: openmpi: Add memchecker support
@ 2014-05-17  5:55 Eric Bavier
  2014-05-17 10:30 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Bavier @ 2014-05-17  5:55 UTC (permalink / raw)
  To: guix-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-openmpi-Add-memchecker-support.patch --]
[-- Type: text/x-diff, Size: 1781 bytes --]

From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@member.fsf.org>
Date: Sat, 17 May 2014 00:02:44 -0500
Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support

* gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
  [arguments]: Add configure flags for memchecker.
---
 gnu/packages/mpi.scm |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index 37b7858..e525ed8 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -32,6 +32,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages valgrind)
   #:use-module (srfi srfi-1))
 
 (define-public hwloc
@@ -99,7 +100,8 @@ bind processes, and much more.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("gfortran" ,gfortran-4.8)))
+     `(("gfortran" ,gfortran-4.8)
+       ("valgrind" ,valgrind)))
     (arguments
      `(#:configure-flags `("--enable-static"
                            "--enable-oshmem"
@@ -110,6 +112,10 @@ bind processes, and much more.")
                            ;; "--enable-mpi-thread-multiple"
                            "--enable-mpi-ext=all"
                            "--with-devel-headers"
+                           "--enable-debug"
+                           "--enable-memchecker"
+                           ,(string-append "--with-valgrind="
+                                           (assoc-ref %build-inputs "valgrind"))
                            ,(string-append "--with-hwloc="
                                            (assoc-ref %build-inputs "hwloc")))))
     (home-page "http://www.open-mpi.org")
-- 
1.7.9.5


[-- Attachment #2: Type: text/plain, Size: 133 bytes --]


-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
  2014-05-17  5:55 [PATCH 1/4] gnu: openmpi: Add memchecker support Eric Bavier
@ 2014-05-17 10:30 ` Ludovic Courtès
  2014-05-18  0:09   ` Eric Bavier
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2014-05-17 10:30 UTC (permalink / raw)
  To: Eric Bavier; +Cc: guix-devel

Eric Bavier <ericbavier@gmail.com> skribis:

> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 17 May 2014 00:02:44 -0500
> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>
> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>   [arguments]: Add configure flags for memchecker.

[...]

>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
>      (propagated-inputs
> -     `(("gfortran" ,gfortran-4.8)))
> +     `(("gfortran" ,gfortran-4.8)
> +       ("valgrind" ,valgrind)))

Why is Valgrind propagated?  I would expect it to be used only in
Open MPI’s test suite, no?

(I also wonder why GFortran is propagated, probably overlooked it
before.)

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
  2014-05-17 10:30 ` Ludovic Courtès
@ 2014-05-18  0:09   ` Eric Bavier
  2014-05-18 10:06     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Bavier @ 2014-05-18  0:09 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel


Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Sat, 17 May 2014 00:02:44 -0500
>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>
>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>   [arguments]: Add configure flags for memchecker.
>
> [...]
>
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)))
>>      (propagated-inputs
>> -     `(("gfortran" ,gfortran-4.8)))
>> +     `(("gfortran" ,gfortran-4.8)
>> +       ("valgrind" ,valgrind)))
>
> Why is Valgrind propagated?  I would expect it to be used only in
> OpenMPI’s test suite, no?

The intention of OpenMPI's memchecker option is to allow one to more
easily use valgrind when executing mpi programs.  That being said, it is
an optional feature, so it may not need to be propagated.  I'll look at
that again.

>
> (I also wonder why GFortran is propagated, probably overlooked it
> before.)

GFortran needs to be propagated for the OpenMPI compiler wrappers.

-- 
Eric Bavier

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/4] gnu: openmpi: Add memchecker support
  2014-05-18  0:09   ` Eric Bavier
@ 2014-05-18 10:06     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2014-05-18 10:06 UTC (permalink / raw)
  To: Eric Bavier; +Cc: guix-devel

Eric Bavier <ericbavier@gmail.com> skribis:

> Ludovic Courtès writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>>> From: Eric Bavier <bavier@member.fsf.org>
>>> Date: Sat, 17 May 2014 00:02:44 -0500
>>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>>
>>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>>   [arguments]: Add configure flags for memchecker.
>>
>> [...]
>>
>>>      (native-inputs
>>>       `(("pkg-config" ,pkg-config)))
>>>      (propagated-inputs
>>> -     `(("gfortran" ,gfortran-4.8)))
>>> +     `(("gfortran" ,gfortran-4.8)
>>> +       ("valgrind" ,valgrind)))
>>
>> Why is Valgrind propagated?  I would expect it to be used only in
>> OpenMPI’s test suite, no?
>
> The intention of OpenMPI's memchecker option is to allow one to more
> easily use valgrind when executing mpi programs.  That being said, it is
> an optional feature, so it may not need to be propagated.  I'll look at
> that again.

But that still makes Valgrind optional when using Open MPI, no?  I would
not propagate it if it’s optional.

>> (I also wonder why GFortran is propagated, probably overlooked it
>> before.)
>
> GFortran needs to be propagated for the OpenMPI compiler wrappers.

OK.  I would not propagate it either because, suppose you just want to
use the library in a C program, then it doesn’t make sense to pull the
Fortran compiler.

WDYT?

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-05-18 10:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17  5:55 [PATCH 1/4] gnu: openmpi: Add memchecker support Eric Bavier
2014-05-17 10:30 ` Ludovic Courtès
2014-05-18  0:09   ` Eric Bavier
2014-05-18 10:06     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).