From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add gsegrafix and depdendent libraries.
Date: Mon, 26 May 2014 00:38:20 +0200
Message-ID: <87vbstxz4z.fsf@gnu.org>
References: <1401007682-24126-1-git-send-email-jmd@gnu.org>
	<87d2f20xrv.fsf@gnu.org> <20140525163805.GA19414@jocasta.intra>
	<87k399zh1q.fsf@gnu.org> <20140525214613.GA6902@intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Woh3l-0002Q3-Jt
	for guix-devel@gnu.org; Sun, 25 May 2014 18:38:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Woh3h-0002qw-1Z
	for guix-devel@gnu.org; Sun, 25 May 2014 18:38:29 -0400
In-Reply-To: <20140525214613.GA6902@intra> (John Darrington's message of "Sun,
	25 May 2014 23:46:14 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sun, May 25, 2014 at 11:26:09PM +0200, Ludovic Court=C3=A8s wrote:
>      John Darrington <john@darrington.wattle.id.au> skribis:
>=20=20=20=20=20=20
>      >      > +   (arguments
>      >      > +    ;; The programmer kindly gives us a hook to turn off d=
eprecation warnings ...
>      >      > +    `(#:configure-flags '("DISABLE_DEPRECATED_CFLAGS=3D-DG=
LIB_DISABLE_DEPRECATION_WARNINGS")
>      >=20=20=20=20=20=20
>      >      Would passing CPPFLAGS=3D-DGLIB_DISABLE_DEPRECATION_WARNINGS =
as
>      >      #:configure-flags work?  If yes, that???s preferable to modif=
ying
>      >      Makefile.in.
>      >=20=20=20=20=20=20
>      > Unfortunately not.  This has been hardcoded in Makefile.am :(
>=20=20=20=20=20=20
>      What is that that=E2=80=99s been hard-coded?  Normally, Automake-gen=
erated
>      makefiles honor the user=E2=80=99s CPPFLAGS environment/makefile var=
iable.
>=20=20=20=20=20=20
> Sure.  I can pass additional flags with CPPFLAGS.  But I cannot turn off
> ones which Makefile.am puts there.

Oh, and the problem is that Makefile.am does -DG_DISABLE_DEPRECATED,
which is exactly the opposite of what we want.  I see now.  So yes,
looks like it has to be done this way.

Ludo=E2=80=99.