ludo@gnu.org (Ludovic Courtès) writes:

>> +  (package
>> +    (name "conkeror")
>> +    (version "1.0pre1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri
>> +               (string-append "http://repo.or.cz/w/conkeror.git/snapshot/"
>> +                              "8a26fff5896a3360549e2adfbf06b1d57e909266"
>> +                              ".tar.gz"))
>
> Normally we provide only released versions.  If the last official
> release is too old or broken, could you add a comment stating why we
> take this one?

This is the last tagged commit from the repository.

>> +    (native-inputs `(("tar" ,tar)
>> +                     ("gzip" ,gzip)))
>
> This should not be needed because these are implicit inputs.

It is needed because the `trivial' build system is used.

>> +Mozilla XULRunner which is the base of all Mozilla products including
>> +Firefox. Conkeror has a sophisticated keyboard system for running commands and

[...]

>> +Despite its very similar sounding name, Conkeror is not related to the KDE web
>> +browser and file manager Konqueror in any way. ")
>
> If you could make it one paragraph shorter, that’d be great.

Done.

>> +    (license (list license:gpl2
>> +                   license:lgpl2.1))))
>
> Could you add a comment saying if this is dual-licensing, or something
> else?  Also, did you mean ‘gpl2+’ and ‘lgpl2.1+’?

Unfortunately they don't use the "or (at your option) any later version"
clause:

  Unless otherwise stated, use, modification, and distribution are
  subject to the terms of the Mozilla Public License Version 1.1.
  Alternatively, (at your option) use, modification, and distribution
  are instead subject to the terms of either the GNU General Public
  License Version 2 or the GNU Lesser General Public License Version
  2.1.  The text of these licenses follows.

> This one looks good.  I’m wondering if it would make sense to take
> xulrunner from the IceCat sources, but I’m not sure IceCat modifies
> xulrunner itself.  Ideas?

Alírio Eyng <alirioeyng@gmail.com> writes:

> I use "abrowser -app conkeror/application.ini"; xulrunner isn't needed
> at all, just a script...

This approach is used now.

Regards
Cyrill