* gnu: Add weechat
@ 2014-09-11 20:34 lemonnierk
2014-09-11 21:31 ` Eric Bavier
0 siblings, 1 reply; 5+ messages in thread
From: lemonnierk @ 2014-09-11 20:34 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 5730 bytes --]
Hi,
I have enabled all the plugins (python, perl, lua, tcl, aspell and ofcourse guile) except ruby
that I commented out until a package exists.
From 8d8d1e052623d052834c84cbf433d5ca95c6e513 Mon Sep 17 00:00:00 2001
From: Kevin Lemonnier <lemonnierk@ulrar.net>
Date: Fri, 12 Sep 2014 00:32:20 +0200
Subject: [PATCH] gnu: Add weechat
* gnu/packages/weechat.scm: New file
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
gnu-system.am | 1 +
gnu/packages/weechat.scm | 102 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 103 insertions(+)
create mode 100644 gnu/packages/weechat.scm
diff --git a/gnu-system.am b/gnu-system.am
index f09b4d6..44cdd27 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -249,6 +249,7 @@ GNU_SYSTEM_MODULES = \
gnu/packages/w3m.scm \
gnu/packages/wdiff.scm \
gnu/packages/web.scm \
+ gnu/packages/weechat.scm \
gnu/packages/wget.scm \
gnu/packages/which.scm \
gnu/packages/wordnet.scm \
diff --git a/gnu/packages/weechat.scm b/gnu/packages/weechat.scm
new file mode 100644
index 0000000..2391017
--- /dev/null
+++ b/gnu/packages/weechat.scm
@@ -0,0 +1,102 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright 2014 Kevin Lemonnier <lemonnierk@ulrar.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages weechat)
+ #:use-module (gnu packages ncurses)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages gettext)
+ #:use-module (gnu packages gnupg)
+ #:use-module (gnu packages file)
+ #:use-module (gnu packages compression)
+ #:use-module (gnu packages lua)
+; #:use-module (gnu packages ruby)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages perl)
+ #:use-module (gnu packages tcl)
+ #:use-module (gnu packages aspell)
+ #:use-module (gnu packages curl)
+ #:use-module (gnu packages gnutls)
+ #:use-module (gnu packages guile)
+ #:use-module (gnu packages openssl)
+ #:use-module (gnu packages cyrus-sasl)
+ #:use-module (gnu packages autogen)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (guix packages)
+ #:use-module (guix download)
+ #:use-module (guix build-system gnu)
+ #:use-module ((guix licenses) #:select (gpl3)))
+
+(define-public weechat
+ (package
+ (name "weechat")
+ (version "1.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://weechat.org/files/src/weechat-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "1z17wyrl5fp697qp44srpmzk79w37f5hm1r0krffbmga6sbzdj3x"))))
+ (build-system gnu-build-system)
+ (native-inputs `(("autoconf", autoconf)
+ ("pkg-config", pkg-config)))
+ (inputs `(("ncurses", ncurses)
+ ("diffutils", diffutils)
+ ("gettext", gnu-gettext)
+ ("automake", automake)
+ ("libtool", libtool "bin")
+ ("libtool", libtool "out")
+ ("libgcrypt", libgcrypt "out")
+ ("file", file)
+ ("zlib", zlib)
+ ("aspell", aspell)
+ ("curl", curl)
+ ("gnutls", gnutls)
+ ("guile", guile-2.0)
+ ("openssl", openssl)
+ ("cyrus-sasl", cyrus-sasl)
+ ("lua", lua-5.1)
+; ("ruby", ruby)
+ ("python", python-2)
+ ("perl", perl)
+ ("tcl", tcl)
+ ("autogen", autogen)))
+ (arguments `(#:configure-flags (list
+ (string-append
+ "--with-tclconfig="
+ (assoc-ref %build-inputs "tcl") "/lib"))
+ #:phases (alist-cons-after
+ 'autogen 'fix-file
+ (lambda _
+ (substitute*
+ '("configure")
+ (("/usr/bin/file") (which "file"))))
+ (alist-cons-before
+ 'configure 'autogen
+ (lambda _
+ (zero? (system* "./autogen.sh")))
+ %standard-phases))))
+ (synopsis "Fast, light and extensible ncurses chat client")
+ (description "WeeChat (Wee Enhanced Environment for Chat) is a free
+and open-source Internet Relay Chat client, which is designed to be
+light and fast. The client uses a curses frontend, and there are
+remote interfaces for Web, Qt, Android and Emacs. In WeeChat
+everything can be done with a keyboard, though it also supports mouse.
+It is customizable and extensible with plugins and scripts.")
+ (home-page "http://www.weechat.org/")
+ (license gpl3)))
--
1.8.4
--
Kevin Lemonnier
PGP Fingerprint : C123 47CA 9E64 FCF0 3907
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: gnu: Add weechat
2014-09-11 20:34 gnu: Add weechat lemonnierk
@ 2014-09-11 21:31 ` Eric Bavier
2014-09-11 21:53 ` lemonnierk
0 siblings, 1 reply; 5+ messages in thread
From: Eric Bavier @ 2014-09-11 21:31 UTC (permalink / raw)
To: lemonnierk; +Cc: guix-devel
Just some stylistic comments:
lemonnierk@ulrar.net writes:
> From 8d8d1e052623d052834c84cbf433d5ca95c6e513 Mon Sep 17 00:00:00 2001
> From: Kevin Lemonnier <lemonnierk@ulrar.net>
> Date: Fri, 12 Sep 2014 00:32:20 +0200
> Subject: [PATCH] gnu: Add weechat
>
> * gnu/packages/weechat.scm: New file
Period at the end.
> diff --git a/gnu/packages/weechat.scm b/gnu/packages/weechat.scm
> new file mode 100644
> index 0000000..2391017
> --- /dev/null
> +++ b/gnu/packages/weechat.scm
> @@ -0,0 +1,102 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright 2014 Kevin Lemonnier <lemonnierk@ulrar.net>
You might also include the <copyright-sign> that is present in other
source headers.
> +(define-module (gnu packages weechat)
> + #:use-module (gnu packages ncurses)
> + #:use-module (gnu packages base)
> + #:use-module (gnu packages gettext)
> + #:use-module (gnu packages gnupg)
> + #:use-module (gnu packages file)
> + #:use-module (gnu packages compression)
> + #:use-module (gnu packages lua)
> +; #:use-module (gnu packages ruby)
Rather than commenting-out the #:use-module and the input, could we
instead leave a TODO comment to add ruby at a later date?
> +(define-public weechat
> + (package
> + (name "weechat")
> + (version "1.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://weechat.org/files/src/weechat-"
> + version ".tar.gz"))
> + (sha256
> + (base32 "1z17wyrl5fp697qp44srpmzk79w37f5hm1r0krffbmga6sbzdj3x"))))
> + (build-system gnu-build-system)
> + (native-inputs `(("autoconf", autoconf)
Put the unquote ',' directly before the symbol that is being unquoted.
> + ("pkg-config", pkg-config)))
> + (inputs `(("ncurses", ncurses)
> + ("diffutils", diffutils)
> + ("gettext", gnu-gettext)
> + ("automake", automake)
> + ("libtool", libtool "bin")
> + ("libtool", libtool "out")
> + ("libgcrypt", libgcrypt "out")
> + ("file", file)
I'm guessing that 'file' should be a native-input. Is it run during the
build, or also at runtime?
> + ("zlib", zlib)
> + ("aspell", aspell)
> + ("curl", curl)
> + ("gnutls", gnutls)
> + ("guile", guile-2.0)
> + ("openssl", openssl)
> + ("cyrus-sasl", cyrus-sasl)
> + ("lua", lua-5.1)
> +; ("ruby", ruby)
See comment above.
> + ("python", python-2)
> + ("perl", perl)
> + ("tcl", tcl)
> + ("autogen", autogen)))
> + (arguments `(#:configure-flags (list
> + (string-append
> + "--with-tclconfig="
> + (assoc-ref %build-inputs "tcl") "/lib"))
> + #:phases (alist-cons-after
> + 'autogen 'fix-file
> + (lambda _
> + (substitute*
> + '("configure")
Put "configure" on the same line as substitute*. If it's a single file,
substitute* will accept it on its own, i.e. (substitute* "configure" ...).
> + (("/usr/bin/file") (which "file"))))
> + (alist-cons-before
> + 'configure 'autogen
> + (lambda _
> + (zero? (system* "./autogen.sh")))
> + %standard-phases))))
> + (synopsis "Fast, light and extensible ncurses chat client")
> + (description "WeeChat (Wee Enhanced Environment for Chat) is a free
> +and open-source Internet Relay Chat client, which is designed to be
Leave out the "free and open-source" bit since, as Ludo would say, we're
already in the land of freedom. ;)
Thanks!
--
Eric Bavier
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gnu: Add weechat
2014-09-11 21:31 ` Eric Bavier
@ 2014-09-11 21:53 ` lemonnierk
2014-09-11 22:17 ` Eric Bavier
0 siblings, 1 reply; 5+ messages in thread
From: lemonnierk @ 2014-09-11 21:53 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 10219 bytes --]
Thanks for the comments, here is a new patch hopefully addressing those.
I had a little trouble copying the © with emacs at first, don't know why
it wasn't in my first patch :).
From d0ade7847532749120946abe2c8e8810ad96b501 Mon Sep 17 00:00:00 2001
From: Kevin Lemonnier <lemonnierk@ulrar.net>
Date: Fri, 12 Sep 2014 01:49:22 +0200
Subject: [PATCH] gnu: Add weechat
* gnu/packages/weechat.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
gnu-system.am | 1 +
gnu/packages/weechat.scm | 101 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 102 insertions(+)
create mode 100644 gnu/packages/weechat.scm
diff --git a/gnu-system.am b/gnu-system.am
index f09b4d6..44cdd27 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -249,6 +249,7 @@ GNU_SYSTEM_MODULES = \
gnu/packages/w3m.scm \
gnu/packages/wdiff.scm \
gnu/packages/web.scm \
+ gnu/packages/weechat.scm \
gnu/packages/wget.scm \
gnu/packages/which.scm \
gnu/packages/wordnet.scm \
diff --git a/gnu/packages/weechat.scm b/gnu/packages/weechat.scm
new file mode 100644
index 0000000..2a445fa
--- /dev/null
+++ b/gnu/packages/weechat.scm
@@ -0,0 +1,101 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Kevin Lemonnier <lemonnierk@ulrar.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+;; TODO: Add ruby
+
+(define-module (gnu packages weechat)
+ #:use-module (gnu packages ncurses)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages gettext)
+ #:use-module (gnu packages gnupg)
+ #:use-module (gnu packages file)
+ #:use-module (gnu packages compression)
+ #:use-module (gnu packages lua)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages perl)
+ #:use-module (gnu packages tcl)
+ #:use-module (gnu packages aspell)
+ #:use-module (gnu packages curl)
+ #:use-module (gnu packages gnutls)
+ #:use-module (gnu packages guile)
+ #:use-module (gnu packages openssl)
+ #:use-module (gnu packages cyrus-sasl)
+ #:use-module (gnu packages autogen)
+ #:use-module (gnu packages autotools)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (guix packages)
+ #:use-module (guix download)
+ #:use-module (guix build-system gnu)
+ #:use-module ((guix licenses) #:select (gpl3)))
+
+(define-public weechat
+ (package
+ (name "weechat")
+ (version "1.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://weechat.org/files/src/weechat-"
+ version ".tar.gz"))
+ (sha256
+ (base32 "1z17wyrl5fp697qp44srpmzk79w37f5hm1r0krffbmga6sbzdj3x"))))
+ (build-system gnu-build-system)
+ (native-inputs `(("autoconf" ,autoconf)
+ ("pkg-config" ,pkg-config)
+ ("file" ,file)
+ ("autogen" ,autogen)
+ ("automake" ,automake)))
+ (inputs `(("ncurses" ,ncurses)
+ ("diffutils" ,diffutils)
+ ("gettext" ,gnu-gettext)
+ ("libtool" ,libtool "bin")
+ ("libtool" ,libtool "out")
+ ("libgcrypt" ,libgcrypt "out")
+ ("zlib" ,zlib)
+ ("aspell" ,aspell)
+ ("curl" ,curl)
+ ("gnutls" ,gnutls)
+ ("guile" ,guile-2.0)
+ ("openssl" ,openssl)
+ ("cyrus-sasl" ,cyrus-sasl)
+ ("lua" ,lua-5.1)
+ ("python" ,python-2)
+ ("perl" ,perl)
+ ("tcl" ,tcl)))
+ (arguments `(#:configure-flags (list
+ (string-append
+ "--with-tclconfig="
+ (assoc-ref %build-inputs "tcl") "/lib"))
+ #:phases (alist-cons-after
+ 'autogen 'fix-file
+ (lambda _
+ (substitute* "configure"
+ (("/usr/bin/file") (which "file"))))
+ (alist-cons-before
+ 'configure 'autogen
+ (lambda _
+ (zero? (system* "./autogen.sh")))
+ %standard-phases))))
+ (synopsis "Fast, light and extensible ncurses chat client")
+ (description "WeeChat (Wee Enhanced Environment for Chat) is a
+Internet Relay Chat client, which is designed to be light and fast.
+The client uses a curses frontend, and there are remote interfaces
+for Web, Qt, Android and Emacs. In WeeChat everything can be done
+with a keyboard, though it also supports mouse. It is customizable
+and extensible with plugins and scripts.")
+ (home-page "http://www.weechat.org/")
+ (license gpl3)))
--
1.8.4
On Thu, Sep 11, 2014 at 04:31:07PM -0500, Eric Bavier wrote:
>
> Just some stylistic comments:
>
> lemonnierk@ulrar.net writes:
>
> > From 8d8d1e052623d052834c84cbf433d5ca95c6e513 Mon Sep 17 00:00:00 2001
> > From: Kevin Lemonnier <lemonnierk@ulrar.net>
> > Date: Fri, 12 Sep 2014 00:32:20 +0200
> > Subject: [PATCH] gnu: Add weechat
> >
> > * gnu/packages/weechat.scm: New file
>
> Period at the end.
>
> > diff --git a/gnu/packages/weechat.scm b/gnu/packages/weechat.scm
> > new file mode 100644
> > index 0000000..2391017
> > --- /dev/null
> > +++ b/gnu/packages/weechat.scm
> > @@ -0,0 +1,102 @@
> > +;;; GNU Guix --- Functional package management for GNU
> > +;;; Copyright 2014 Kevin Lemonnier <lemonnierk@ulrar.net>
>
> You might also include the <copyright-sign> that is present in other
> source headers.
>
> > +(define-module (gnu packages weechat)
> > + #:use-module (gnu packages ncurses)
> > + #:use-module (gnu packages base)
> > + #:use-module (gnu packages gettext)
> > + #:use-module (gnu packages gnupg)
> > + #:use-module (gnu packages file)
> > + #:use-module (gnu packages compression)
> > + #:use-module (gnu packages lua)
> > +; #:use-module (gnu packages ruby)
>
> Rather than commenting-out the #:use-module and the input, could we
> instead leave a TODO comment to add ruby at a later date?
>
> > +(define-public weechat
> > + (package
> > + (name "weechat")
> > + (version "1.0")
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "http://weechat.org/files/src/weechat-"
> > + version ".tar.gz"))
> > + (sha256
> > + (base32 "1z17wyrl5fp697qp44srpmzk79w37f5hm1r0krffbmga6sbzdj3x"))))
> > + (build-system gnu-build-system)
> > + (native-inputs `(("autoconf", autoconf)
>
> Put the unquote ',' directly before the symbol that is being unquoted.
>
> > + ("pkg-config", pkg-config)))
> > + (inputs `(("ncurses", ncurses)
> > + ("diffutils", diffutils)
> > + ("gettext", gnu-gettext)
> > + ("automake", automake)
> > + ("libtool", libtool "bin")
> > + ("libtool", libtool "out")
> > + ("libgcrypt", libgcrypt "out")
> > + ("file", file)
>
> I'm guessing that 'file' should be a native-input. Is it run during the
> build, or also at runtime?
>
> > + ("zlib", zlib)
> > + ("aspell", aspell)
> > + ("curl", curl)
> > + ("gnutls", gnutls)
> > + ("guile", guile-2.0)
> > + ("openssl", openssl)
> > + ("cyrus-sasl", cyrus-sasl)
> > + ("lua", lua-5.1)
> > +; ("ruby", ruby)
>
> See comment above.
>
> > + ("python", python-2)
> > + ("perl", perl)
> > + ("tcl", tcl)
> > + ("autogen", autogen)))
> > + (arguments `(#:configure-flags (list
> > + (string-append
> > + "--with-tclconfig="
> > + (assoc-ref %build-inputs "tcl") "/lib"))
> > + #:phases (alist-cons-after
> > + 'autogen 'fix-file
> > + (lambda _
> > + (substitute*
> > + '("configure")
>
> Put "configure" on the same line as substitute*. If it's a single file,
> substitute* will accept it on its own, i.e. (substitute* "configure" ...).
>
> > + (("/usr/bin/file") (which "file"))))
> > + (alist-cons-before
> > + 'configure 'autogen
> > + (lambda _
> > + (zero? (system* "./autogen.sh")))
> > + %standard-phases))))
> > + (synopsis "Fast, light and extensible ncurses chat client")
> > + (description "WeeChat (Wee Enhanced Environment for Chat) is a free
> > +and open-source Internet Relay Chat client, which is designed to be
>
> Leave out the "free and open-source" bit since, as Ludo would say, we're
> already in the land of freedom. ;)
>
> Thanks!
>
> --
> Eric Bavier
>
> Please avoid sending me Word or PowerPoint attachments.
> See http://www.gnu.org/philosophy/no-word-attachments.html
--
Kevin Lemonnier
PGP Fingerprint : C123 47CA 9E64 FCF0 3907
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: gnu: Add weechat
2014-09-11 21:53 ` lemonnierk
@ 2014-09-11 22:17 ` Eric Bavier
2014-09-11 22:21 ` lemonnierk
0 siblings, 1 reply; 5+ messages in thread
From: Eric Bavier @ 2014-09-11 22:17 UTC (permalink / raw)
To: lemonnierk; +Cc: guix-devel
lemonnierk@ulrar.net writes:
> From d0ade7847532749120946abe2c8e8810ad96b501 Mon Sep 17 00:00:00 2001
> From: Kevin Lemonnier <lemonnierk@ulrar.net>
> Date: Fri, 12 Sep 2014 01:49:22 +0200
> Subject: [PATCH] gnu: Add weechat
>
> * gnu/packages/weechat.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
I've applied your patch in f489668 with some minor changes:
> + (synopsis "Fast, light and extensible ncurses chat client")
I changed this to "Extensible chat client" to be concise.
> + (description "WeeChat (Wee Enhanced Environment for Chat) is a
> +Internet Relay Chat client, which is designed to be light and fast.
> +The client uses a curses frontend, and there are remote interfaces
> +for Web, Qt, Android and Emacs. In WeeChat everything can be done
> +with a keyboard, though it also supports mouse. It is customizable
> +and extensible with plugins and scripts.")
changed to "*an* Internet..." and double spaces after end-of-sentence
period.
Thanks again!
--
Eric Bavier
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gnu: Add weechat
2014-09-11 22:17 ` Eric Bavier
@ 2014-09-11 22:21 ` lemonnierk
0 siblings, 0 replies; 5+ messages in thread
From: lemonnierk @ 2014-09-11 22:21 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
> I've applied your patch in f489668 with some minor changes:
Thanks !
> changed to "*an* Internet..." and double spaces after end-of-sentence
> period.
I wondered if I had to put a or an, good to know !
--
Kevin Lemonnier
PGP Fingerprint : C123 47CA 9E64 FCF0 3907
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-11 22:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 20:34 gnu: Add weechat lemonnierk
2014-09-11 21:31 ` Eric Bavier
2014-09-11 21:53 ` lemonnierk
2014-09-11 22:17 ` Eric Bavier
2014-09-11 22:21 ` lemonnierk
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).