From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends. Date: Wed, 17 Dec 2014 21:34:40 +0100 Message-ID: <87vblahv6n.fsf@gnu.org> References: <878ui8edzl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1LJ1-0003JS-Nk for guix-devel@gnu.org; Wed, 17 Dec 2014 15:34:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1LIx-0003eN-Dv for guix-devel@gnu.org; Wed, 17 Dec 2014 15:34:47 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:51121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1LIx-0003d7-23 for guix-devel@gnu.org; Wed, 17 Dec 2014 15:34:43 -0500 In-Reply-To: (Federico Beffa's message of "Wed, 17 Dec 2014 20:25:33 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Federico Beffa Cc: Guix-devel Federico Beffa skribis: > On Mon, Dec 15, 2014 at 11:37 PM, Ludovic Court=C3=A8s wro= te: >> One should get a message about GI_TYPELIB_PATH, but only if >> gobject-introspection is also installed. Not sure if that helps. > > My question was actually how to produce the message. Is that > automatically handled by the 'search-path' directive in the package? Yes, exactly. As an example, if you install both Guile and Guile-JSON, =E2=80=98guix pack= age=E2=80=99 will invite you to define GUILE_LOAD_PATH if it=E2=80=99s not already defin= ed. And then, =E2=80=98guix package --search-paths=E2=80=99 will display all th= e environment variables that should be defined. >>> + (propagated-inputs >>> + `(("python-pyparsing" ,python-pyparsing) >>> + ("python-pygobject" ,python-pygobject) >> >> Could you add a comment saying why they=E2=80=99re here? > > Hope my comment is enough :-) It=E2=80=99s perfect! >> >>> (native-inputs >>> `(("pkg-config" ,pkg-config) >>> ("texlive" ,texlive) >>> + ("ghostscript" ,ghostscript) >> >> This doesn=E2=80=99t sound GTK-related, no? > > This is an optional dependency and I initially thought to add it to > make the package more "complete". After your comment I decided to look > after what it is actually used for. I learned that it is "only" needed > as one component necessary to make matplotlib able to render text > through LaTeX. So, if we do not make texlive a propagated-input of > matplotlib, then ghostscript is not really needed and I've removed it > again. > > Given the size of texlive I'm hesitant in making it a > propagated-input. However, it would make it possible to produce > pictures with the same fonts as the ones used in a latex document, > which is quite nice. > > What do you think? I think TeXLive shouldn=E2=80=99t be a propagated input, nor even something referenced by the package output. Perhaps the LaTeX functionality magically becomes available when =E2=80=98pdflatex=E2=80=99 or similar is found in $PATH, in which case ther= e=E2=80=99s nothing to do: users who care would explicitly install TeX Live in their profile and get that functionality. WDYT? > From 4eb7c8dff92f641391c0d902e1ab43536ce0d763 Mon Sep 17 00:00:00 2001 > From: Federico Beffa > Date: Thu, 11 Dec 2014 14:26:13 +0100 > Subject: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends and optional > dependency. Adjust inputs. > > * gnu/packages/python.scm (python-matplotlib, python2-matplotlib): Add gt= k3 > backends with the necessary inputs and a 'configure-environment' phase.= Add > the optional 'python-pillow' dependency. Move 'python-pyparsing' from > 'inputs' to 'propagated-inputs' as it is required at run time. LGTM, thanks! Ludo=E2=80=99.