From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] environment: Add --inclusive option.
Date: Fri, 20 Mar 2015 20:20:14 +0100
Message-ID: <87vbhv8oi9.fsf@gnu.org>
References: <87r3slzw5i.fsf@fsf.org> <87lhitzvzx.fsf@fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZ2T1-0005PX-3C
	for guix-devel@gnu.org; Fri, 20 Mar 2015 15:20:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZ2Sv-0004Ky-Ll
	for guix-devel@gnu.org; Fri, 20 Mar 2015 15:20:23 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40906)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YZ2Sv-0004Ku-Jm
	for guix-devel@gnu.org; Fri, 20 Mar 2015 15:20:17 -0400
In-Reply-To: <87lhitzvzx.fsf@fsf.org> (David Thompson's message of "Wed, 18
	Mar 2015 20:11:46 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> From 3d97dbcf1907a67ed25fd90c09eb88d1b136d31a Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Wed, 18 Mar 2015 20:01:12 -0400
> Subject: [PATCH 2/2] environment: Add --inclusive option.
>
> * guix/scripts/environment.scm (show-help): Add help.
>   (%default-options): Add 'inclusive?'.
>   (%options): Add 'inclusive' option.
>   (packages->transitive-inputs): Add 'inclusive?' argument.
>   (guix-environment): Use 'inclusive' option.

It=E2=80=99s a good idea.

Though I guess in the SDL example and similar use cases, it=E2=80=99s often
enough to make an environment that contains PACKAGES as their propagated
inputs (recursively), but not their inputs.

> +@item --inclusive
> +@item -i
> +Include @var{packages}@dots{} in the new environment in addition to
> +their inputs.  Useful for creating an environment from arbitrary
                 ^^
=E2=80=9CThis is useful for=E2=80=9D

> +  -i, --inclusive        include PACKAGE... in new environment"))

=E2=80=9Cin the new environment=E2=80=9D

OK to push with these changes, thank you!

Ludo=E2=80=99.