From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH] gnu: Add adwaita-icon-theme.
Date: Wed, 13 May 2015 09:19:13 +0800
Message-ID: <87vbfxqnou.fsf@gmail.com>
References: <1431427501-25929-1-git-send-email-iyzsong@gmail.com>
	<87mw19y2iy.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1YsLJq-0001K6-8t
	for guix-devel@gnu.org; Tue, 12 May 2015 21:18:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1YsLJp-0006AU-8P
	for guix-devel@gnu.org; Tue, 12 May 2015 21:18:42 -0400
In-Reply-To: <87mw19y2iy.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable.
>
> [...]
>
>> +(define-public adwaita-icon-theme
>> +  (package (inherit gnome-icon-theme)
>> +    (name "adwaita-icon-theme")
>> +    (version "3.16.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://gnome/sources/" name "/"
>> +                                  (version-major+minor version) "/"
>> +                                  name "-" version ".tar.xz"))
>> +              (sha256
>> +               (base32
>> +                "1cbfdypxfg74krqrklh4za64jhvskbp206l14fs739cw14xsvj53")=
)))
>> +    (native-inputs
>> +     ;; XXX: gtk-encode-symbolic-svg lacks SVG support.
>> +     (alist-delete "gtk+" (package-native-inputs gnome-icon-theme)))))
>
> Why is this =E2=80=98alist-delete=E2=80=99 needed?  Perhaps you just need=
 to expound the
> comment.
With 'gtk+', it will:
1. use gtk-update-icon-cache to build a index-theme.cache       (ok)
2. use gtk-encode-symbolic-svg to convert symbolic SVGs to PNGs (failed)

The reason is gtk-encode-symbolic-svg lacks librsvg support for
gdk-pixbuf, maybe we should wrap it with GDK_PIXBUF_MODULE_FILE.
>
> Also, I think specific =E2=80=98synopsis=E2=80=99 and =E2=80=98descriptio=
n=E2=80=99 need to be
> provided.
The gnome-icon-theme was renamed to adwaita-icon-theme after 3.12,
So, I think the 'synopsis' and 'description' applied too.
>
> WDYT?
I plan to fix the 'gtk-encode-symbolic-svg' and remove the
'alist-delete'.

Thanks for review!
>
> Thanks,
> Ludo=E2=80=99.