From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add adwaita-icon-theme.
Date: Fri, 22 May 2015 15:16:02 +0200
Message-ID: <87vbfklpm5.fsf@gnu.org>
References: <1431427501-25929-1-git-send-email-iyzsong@gmail.com>
	<87mw19y2iy.fsf@gnu.org> <87vbfxqnou.fsf@gmail.com>
	<87fv70x660.fsf@gnu.org> <87r3qdvtk1.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35936)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yvmo7-0007EJ-Jf
	for guix-devel@gnu.org; Fri, 22 May 2015 09:16:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yvmo1-0005NN-V2
	for guix-devel@gnu.org; Fri, 22 May 2015 09:16:11 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49920)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yvmo1-0005NH-S5
	for guix-devel@gnu.org; Fri, 22 May 2015 09:16:05 -0400
In-Reply-To: <87r3qdvtk1.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Tue, 19 May 2015 16:51:42 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> From ff7e16bc8b7e803d49d5ee880f31f3f4e1660d3c Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Tue, 19 May 2015 16:32:09 +0800
> Subject: [PATCH 1/2] gnu: gtk+: Add SVG support to 'gtk-encode-symbolic-s=
vg'.
>
> * gnu/packages/gtk.scm (gtk+)[inputs]: Add librsvg.
>   [arguments]: Add 'wrap-gtk-encode-symbolic-svg' phase.

[...]

> +        'install 'wrap-gtk-encode-symbolic-svg
> +        (lambda* (#:key inputs outputs #:allow-other-keys)
> +          (let* ((out (assoc-ref outputs "out"))
> +                 (prog (string-append out "/bin/gtk-encode-symbolic-svg"=
))
> +                 (librsvg (assoc-ref inputs "librsvg"))
> +                 (loaders.cache (find-files librsvg "^loaders\\.cache$")=
))
> +            (wrap-program prog
> +              `("GDK_PIXBUF_MODULE_FILE" =3D ,loaders.cache))))
> +        %standard-phases))))))

Could you add a comment there explaining what=E2=80=99s going on?

So =E2=80=98gtk-encode-symbolic-svg=E2=80=99 uses that loader mechanism, wh=
ich is why it
doesn=E2=80=99t actually support SVG out-of-the-box, even if librsvg is alr=
eady
an input, right?

This would have to be committed in a gtk-rebuild branch.

> From f9aa59c1aca6e30f217d7d2e1c8ae5c6774b66c0 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Tue, 12 May 2015 18:42:37 +0800
> Subject: [PATCH 2/2] gnu: Add adwaita-icon-theme.
>
> * gnu/packages/gnome.scm (adwaita-icon-theme): New variable.

OK!

Thanks,
Ludo=E2=80=99.