Re: [PATCH] Add yaggo.

[Mark H Weaver <mhw@netris.org>]

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> From d220bdeac89660108de96a96107daf89182310e0 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Wed, 24 Jun 2015 14:32:26 +1000
> Subject: [PATCH] gnu: Add yaggo.
>
> * gnu/packages/ruby.scm (yaggo): New variable.
> ---
>  gnu/packages/ruby.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index af87cf5..19006d3 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2014 David Thompson <davet@gnu.org>
> +;;; Copyright © 2015 Ben Woodcroft <donttrustben@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -697,3 +698,34 @@ options and parsing command line flags.")
>  net/http library.")
>      (home-page "https://github.com/nicksieger/multipart-post")
>      (license license:expat)))
> +
> +(define-public yaggo
> +  (package
> +   (name "yaggo")
> +   (version "1.5.4")
> +   (source (origin
> +	    (method url-fetch)
> +	    (uri (string-append
> +		  "https://github.com/gmarcais/yaggo/archive/v"
> +		  version ".tar.gz"))
> +	    (file-name (string-append name "-" version ".tar.gz"))
> +	    (sha256
> +	     (base32
> +	      "1mxfvrim03xg80agws9zdpk00r0kjpqhw3xbli0w8wvsnsa274y3"))))

Please change the tabs to spaces.

> +   (build-system ruby-build-system)
> +   (arguments
> +    `(#:tests? #f ;; no rake test, and Makefile in test/ appears malformed

Just one semicolon there, please.  Our convention, borrowed from
<http://mumble.net/~campbell/scheme/style.txt>, is to use one semicolon
for "margin comments", i.e. comments to the right of the code, and two
semicolons for comments on their own line preceding code.

It's made more important by the fact that formatting commands in Emacs
Lisp editing modes will act differently depending on how many semicolon
are present.

> +      #:phases
> +      (modify-phases %standard-phases
> +		     (replace 'build

Please align the "(" under the "o" in "modify-phases"

> +			      (lambda* _

You can use plain 'lambda' here.

> +				(zero? (system* "rake"
> +						"gem")))))))

It would look better to move "gem" to the preceeding line.  Better yet,
how about putting the entire 'replace' on one line, like this:

      (modify-phases %standard-phases
        (replace 'build (lambda _ (zero? (system* "rake" "gem")))))))

Normally I use more whitespace, but in this case I think it's perfectly
readable.  What do you think?

> +   (synopsis "Generate C++ command line parsers using getopt_long")
> +   (description "Yaggo is a tool to generate command line parsers for
> +C++.  Yaggo stands for 'Yet Another GenGetOpt' and is inspired by GNU
> +Gengetopt.  It reads a configuration file describing the switches and argument
> +for a C++ program and it generates one header file that parses the command
> +line using getopt_long(3).")
> +   (home-page "https://github.com/gmarcais/yaggo")
> +   (license license:gpl3+)))

Can you send an updated patch?

    Thanks,
      Mark