Re: [PATCH] emacs: Fill package description in Info buffers.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> Since there is a buffer-local 'fill-column' variable, I think we may use
> it instead of hard-coding '72', so that a user could change it, for
> example like this:
>
> (add-hook 'guix-package-info-mode-hook
>           (lambda () (setq fill-column 60)))

Indeed, it’s better this way.

>> +                (guix-format-insert val (and (facep face) face))
>> +                (fill-region begin (point))
>
> I think it's better to use 'guix-get-filled-string' instead of
> (let ((begin (point))) ... (fill-region begin (point)))

Agreed, I hadn’t noticed that one.

> Actually, I think that preserving the original formatting used in
> "description" fields is a feature, not a bug, as it allows to find too
> long lines or other related things and then to fix those.
>
> (For example, I've just accidentally found that the first line of
> "pulseaudio" description is too long, and when I looked at the source, I
> also noticed that the description ends with a space.  With your change
> it wouldn't be possible to notice :-))

I think I would turn to the source file when I want to nitpick on
description formatting.  ;-)

> But as we can always add another option for a user to choose the variant
> he wants, I agree.  What about the attached modified patch?
>
> Also as it may concern synopsis (when a current window is too small to
> fit the synopsis), I renamed the patch into "emacs: Fill package heading
> in Info buffers."

Your patch looks better indeed.  Please push, thank you!

Ludo’.