From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add oslo.i18n.
Date: Fri, 04 Sep 2015 22:01:26 +0200
Message-ID: <87vbbqdkdl.fsf@gnu.org>
References: <1441148656-303-1-git-send-email-tipecaml@gmail.com>
	<1441148656-303-3-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZXxAz-000624-7c
	for guix-devel@gnu.org; Fri, 04 Sep 2015 16:01:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZXxAv-0000ja-Fi
	for guix-devel@gnu.org; Fri, 04 Sep 2015 16:01:33 -0400
In-Reply-To: <1441148656-303-3-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Wed, 2 Sep 2015 01:04:16 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/openstack.scm (python-oslo.i18n, python2-oslo.i18n): New
>   variables.

[...]

> +    (propagated-inputs
> +      `(("python-babel" ,python-babel)
> +        ("python-six" ,python-six)))
> +    (inputs
> +      `(("python-pbr" ,python-pbr)
> +        ("python-setuptools" ,python-setuptools)
> +        ;; Tests

Shouldn=E2=80=99t python-pbr be propagated?

Also, I=E2=80=99m under the impression that =E2=80=98guix import pypi=E2=80=
=99 adds
python-setuptools even though it=E2=80=99s usually not required, no?

> +    (description "Oslo i18n library")

Please elaborate, and expand =E2=80=9Ci18n.=E2=80=9D

Otherwise LGTM, thanks!

Ludo=E2=80=99.