unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add oslo.i18n.
Date: Fri, 04 Sep 2015 22:01:26 +0200	[thread overview]
Message-ID: <87vbbqdkdl.fsf@gnu.org> (raw)
In-Reply-To: <1441148656-303-3-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Wed, 2 Sep 2015 01:04:16 +0200")

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/openstack.scm (python-oslo.i18n, python2-oslo.i18n): New
>   variables.

[...]

> +    (propagated-inputs
> +      `(("python-babel" ,python-babel)
> +        ("python-six" ,python-six)))
> +    (inputs
> +      `(("python-pbr" ,python-pbr)
> +        ("python-setuptools" ,python-setuptools)
> +        ;; Tests

Shouldn’t python-pbr be propagated?

Also, I’m under the impression that ‘guix import pypi’ adds
python-setuptools even though it’s usually not required, no?

> +    (description "Oslo i18n library")

Please elaborate, and expand “i18n.”

Otherwise LGTM, thanks!

Ludo’.

  reply	other threads:[~2015-09-04 20:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 23:04 [PATCH 0/2] Add oslo.i18n Cyril Roelandt
2015-09-01 23:04 ` [PATCH 1/2] gnu: python-testtools: fix propagated inputs Cyril Roelandt
2015-09-04 19:58   ` Ludovic Courtès
2015-09-01 23:04 ` [PATCH 2/2] gnu: Add oslo.i18n Cyril Roelandt
2015-09-04 20:01   ` Ludovic Courtès [this message]
2015-09-04 20:03     ` Cyril Roelandt
2015-09-04 20:32     ` Thompson, David
2015-09-05 20:26       ` Ludovic Courtès
2015-09-06 20:58         ` Cyril Roelandt
2015-09-06 21:01           ` Ludovic Courtès
2015-09-06 21:19             ` Cyril Roelandt
2015-09-07 22:18 ` [PATCH 0/2] " Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbbqdkdl.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).