From mboxrd@z Thu Jan 1 00:00:00 1970 From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Subject: Re: [PATCH 0/1] Add lz4 (C implementation) Date: Wed, 09 Sep 2015 23:26:36 +0200 Message-ID: <87vbbj5lo3.fsf@T420.taylan> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZmt5-0004ej-Lb for guix-devel@gnu.org; Wed, 09 Sep 2015 17:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZmt4-0006U0-U2 for guix-devel@gnu.org; Wed, 09 Sep 2015 17:26:39 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:36477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZmt4-0006PH-Nn for guix-devel@gnu.org; Wed, 09 Sep 2015 17:26:38 -0400 Received: by wicgb1 with SMTP id gb1so1709024wic.1 for ; Wed, 09 Sep 2015 14:26:37 -0700 (PDT) In-Reply-To: (Leo Famulari's message of "Wed, 9 Sep 2015 17:04:11 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > This patch adds the C reference implementation of the lz4 compression > algorithm. > > I'm looking for advice regarding the tests. The tests take >30 minutes > on my on my quad-core i5 with 8 gigabytes of RAM and they require > Valgrind as a native-input. This seems excessive to me but if users > install binary substitutes, they won't run the tests or need to > install Valgrind, right? And if distributions won't test software, > then who will? Indeed users won't have to go through that unless they build from source, and Valgrind won't become a run-time dependency so long as the produced package does not contain any references to any files from the Valgrind package. Guix contains a lot of software with build and test phases that take a very long time. When I was working on Qt it would take 5 GB of disk space and 6 hours to build every time. Though that was a pathological case and this program is tiny in comparison, I'd still say ~30 minutes is harmless. It's annoying, but that's the price of disciplined work. Taylan