From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH] gnu: Add r-qtl.
Date: Thu, 17 Sep 2015 19:18:10 +0200
Message-ID: <87vbb9hsml.fsf@openmailbox.org>
References: <55facbb7.XMIzNX9aIy6n26s1%pjotr.public12@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZccpO-0008Lu-8v
	for guix-devel@gnu.org; Thu, 17 Sep 2015 13:18:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZccpL-0006xL-4n
	for guix-devel@gnu.org; Thu, 17 Sep 2015 13:18:34 -0400
Received: from smtp22.openmailbox.org ([62.4.1.56]:34128)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZccpK-0006wW-OP
	for guix-devel@gnu.org; Thu, 17 Sep 2015 13:18:30 -0400
In-Reply-To: <55facbb7.XMIzNX9aIy6n26s1%pjotr.public12@thebird.nl> (Pjotr
	Prins's message of "Thu, 17 Sep 2015 16:18:31 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org

Pjotr Prins <pjotr.public12@thebird.nl> writes:

> * gnu/packages/bioinformatics.scm (r-qtl): New variable.
> ---
>  gnu/packages/bioinformatics.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

[...]

> +    (build-system r-build-system)
> +    (home-page "http://www.rqtl.org")
> +    (synopsis "Tools for Analyzing QTL Experiments")
                                      ^^^
Could you modify this be more explicit for a non-specialized audience?
(Also capitalize only the first word.)

> +    (description "Bio-statistics library for analysis of experimental
> +crosses to identify genes (called quantitative trait loci, QTLs)
> +contributing to variation in quantitative traits.")
> +    (license license:gpl3+)))

I don't understand the meaning but on the form side I think QTL sould be
introduced in a full sentence like this "... Quantitative Trait Loci
(QTL) ...".  Can you try to make it more verbose?

Otherwise LGTM.  Thanks.

--
Mathieu Lirzin