unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH 2/2] gnu: Add evilwm.
Date: Fri, 16 Oct 2015 10:37:43 +0200	[thread overview]
Message-ID: <87vba7tdig.fsf@gnu.org> (raw)
In-Reply-To: <1444948609-29345-2-git-send-email-ericbavier@openmailbox.org> (ericbavier@openmailbox.org's message of "Thu, 15 Oct 2015 17:36:49 -0500")

ericbavier@openmailbox.org skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/wm.scm (evilwm): New variable.

[...]

> +                   'build 'provide-better-default-font
> +                   (lambda _
> +                     ;; The "fixed" font is contained in the set of fonts
> +                     ;; installed with the default xorg-server service, so use
> +                     ;; it as the default instead.
> +                     (substitute* "evilwm.h"
> +                       (("^#define DEF_FONT[[:space:]]*\"variable\"")
> +                        "#define DEF_FONT \"fixed\""))

What about adding the “variable” font by default in (gnu services xorg)
instead?

> +    (license (fsf-free "file:///README"))))

Since ‘fsf-free’ is a catch-all thing, could you add a comment
explaining in one line what kind of license this is?

Thank you,
Ludo’.

  reply	other threads:[~2015-10-16  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 22:36 [PATCH 1/2] gnu: Add xlsfonts ericbavier
2015-10-15 22:36 ` [PATCH 2/2] gnu: Add evilwm ericbavier
2015-10-16  8:37   ` Ludovic Courtès [this message]
2015-10-19 11:55     ` Eric Bavier
2015-10-20  7:56       ` Ludovic Courtès
2015-10-20 19:37         ` Eric Bavier
2015-10-16  8:34 ` [PATCH 1/2] gnu: Add xlsfonts Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vba7tdig.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bavier@member.fsf.org \
    --cc=ericbavier@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).