From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 3/3] gnu: Add cmus.
Date: Thu, 22 Oct 2015 08:41:18 +0200
Message-ID: <87vb9ziewh.fsf@elephly.net>
References: <1445253649-1582-1-git-send-email-paul@denknerd.org>
	<1445253649-1582-3-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zp9Z3-0001oO-AX
	for guix-devel@gnu.org; Thu, 22 Oct 2015 02:41:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zp9Yz-0002G9-UR
	for guix-devel@gnu.org; Thu, 22 Oct 2015 02:41:29 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25697)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zp9Yz-0002FV-If
	for guix-devel@gnu.org; Thu, 22 Oct 2015 02:41:25 -0400
In-reply-to: <1445253649-1582-3-git-send-email-paul@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

Hi Paul,

> * gnu/packages/music.scm (cmus): New variable.
> ---
>  gnu/packages/music.scm | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)

[...]

> +(define-public cmus
> +  (package
> +    (name "cmus")
> +    (version "2.7.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/" name "/" name "/archive/v"
> +                    version ".tar.gz"))

Please use ‘(file-name ...)’ here as the tarball is only named
‘v2.7.1.tar.gz’.

> +              (sha256
> +               (base32
> +                "0raixgjavkm7hxppzsc5zqbfbh2bhjcmbiplhnsxsmyj8flafyc1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests?
> +       #f                               ; cmus does not include tests

Putting the ‘#f’ on a separate line looks odd.  Please put ‘#:tests? #f’
on one line together with the margin comment.

[...]

> +       ("pkg-config" ,pkg-config)

This should be in native-inputs instead.

> +       ("pulseaudio" ,pulseaudio)
> +       ("wavpack" ,wavpack)))
> +     (home-page "https://cmus.github.io/")
> +     (synopsis "Small, fast and powerful console music player")
> +     (description "Cmus is a small, fast and powerful console music player for
> +Unix-like operating systems.")

“for Unix-like operating systems” seems redundant as Guix only works on
GNU systems.

> +     (license license:gpl2+)))
> +
>  (define-public hydrogen
>    (package
>      (name "hydrogen")

~~ Ricardo