From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: swh-plugins-lv2: New variable [WIP] v2
Date: Mon, 07 Dec 2015 23:03:51 +0100
Message-ID: <87vb89ncfs.fsf@elephly.net>
References: <5664BA45.3080600@gmx.net> <5664BB8C.6030100@gmx.net>
	<87wpsqm00d.fsf@elephly.net> <5665FD19.3090905@gmx.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1a63t5-0002S8-Qb
	for guix-devel@gnu.org; Mon, 07 Dec 2015 17:04:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1a63t2-0001WI-IN
	for guix-devel@gnu.org; Mon, 07 Dec 2015 17:04:03 -0500
Received: from sender163-mail.zoho.com ([74.201.84.163]:25759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1a63t2-0001Vw-6l
	for guix-devel@gnu.org; Mon, 07 Dec 2015 17:04:00 -0500
In-reply-to: <5665FD19.3090905@gmx.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Florian Paul Schmidt <mista.tapas@gmx.net>
Cc: guix-devel@gnu.org


Florian Paul Schmidt <mista.tapas@gmx.net> writes:

>>> +       (alist-cons-after
>>
>> Please use ‘modify-phases’ instead of the ‘alist-*’ stuff.
>
> OK, noted. I think I searched through other packages to come up with this.
>
> fps@cherry ~/src/guix [env]$ grep "#:phases (alist-cons-after" 
> gnu/packages/*.scm | wc -l
> 53

That’s the way we did things before the nice ‘modify-phases’ macro was
written.  One problem with the ‘alist-*’ stuff is that adding or
removing phases affects the indentation of all following phases, which
makes the output of ‘git diff’ less useful.

~~ Ricardo