From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/6] gnu: Add emacs-constants. Date: Tue, 05 Jan 2016 23:08:36 +0100 Message-ID: <87vb77k7bv.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGZmV-0005NJ-81 for guix-devel@gnu.org; Tue, 05 Jan 2016 17:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGZmR-0002gi-5d for guix-devel@gnu.org; Tue, 05 Jan 2016 17:08:43 -0500 In-Reply-To: (Federico Beffa's message of "Wed, 30 Dec 2015 18:33:24 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Federico Beffa Cc: Guix-devel Federico Beffa skribis: > If found a few times the need to download a single, uncompressed file > which needs to be patched. The available fetch methods do not appear > to be appropriate. So, I've added the function > 'uncompressed-file-fetch'. This and the function > 'broken-tarball-fetch' which currently resides in 'engineering.scm' > should probably belong to '(guix build utils)'. Rather (guix download). > From 6035d4dfd7542a615fbd70bd80527c15424185a3 Mon Sep 17 00:00:00 2001 > From: Federico Beffa > Date: Sat, 26 Dec 2015 11:02:01 +0100 > Subject: [PATCH 4/6] gnu: Add emacs-constants. > > * gnu/packages/emacs.scm (emacs-constants): New variable. > * gnu/packages/patches/emacs-constants-lisp-like.patch: New patch. > * gnu-system.am (dist_patch_DATA): Add it. [...] > +(define* (uncompressed-file-fetch url hash-algo hash > + #:optional name > + #:key (system (%current-system)) > + (guile (default-guile))) > + (mlet %store-monad ((drv (url-fetch url hash-algo hash name > + #:system system > + #:guile guile))) > + (gexp->derivation (or name (basename url)) > + #~(begin > + (mkdir #$output) > + (setenv "PATH" > + (string-append #$gzip "/bin")) > + (chdir #$output) > + (copy-file #$drv (basename #$url)))))) The dependency on gzip can be removed. Also, the second derivation is okay, but kind of wasteful: it only serves to move the file in a directory so the patch-application logic can work. However, I=E2=80=99m unsure the patch in question really belongs here. Aft= er all, there=E2=80=99s just one file, and additionally it=E2=80=99s called = =E2=80=98constants.el=E2=80=99! ;-) > diff --git a/gnu/packages/patches/emacs-constants-lisp-like.patch b/gnu/p= ackages/patches/emacs-constants-lisp-like.patch > new file mode 100644 > index 0000000..5ec37f3 > --- /dev/null > +++ b/gnu/packages/patches/emacs-constants-lisp-like.patch > @@ -0,0 +1,81 @@ > +Add Scheme support This is too terse, and I feel like the patch really does upstream work. It seems that the file has a new home (or is it just a mirror?) at https://github.com/emacsmirror/constants/blob/master/constants.el Is the patch yours? If yes, could you find an upstream to submit it too? If there=E2=80=99s no such thing, you could always become the upstrea= m. ;-) Thanks, Ludo=E2=80=99.