From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: gnu: Add python-wtforms.
Date: Sat, 13 Feb 2016 15:07:17 -0800
Message-ID: <87vb5stdju.fsf@dustycloud.org>
References: <87pow190jn.fsf@dustycloud.org>
	<CAJ=RwfZv+CErcbkcAbWuPa6g9=GW2womkqSZiZXfWx-2g5OSbQ@mail.gmail.com>
	<87io1t8pho.fsf@dustycloud.org> <87ziv4tgzt.fsf@dustycloud.org>
	<20160213222307.GA1127@jasmine> <87wpq8te06.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34946)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aUjHh-0004kc-Qm
	for guix-devel@gnu.org; Sat, 13 Feb 2016 18:07:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aUjHb-0006Yo-MU
	for guix-devel@gnu.org; Sat, 13 Feb 2016 18:07:25 -0500
Received: from dustycloud.org ([50.116.34.160]:36432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aUjHb-0006Yk-Ho
	for guix-devel@gnu.org; Sat, 13 Feb 2016 18:07:19 -0500
In-reply-to: <87wpq8te06.fsf@dustycloud.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>

Christopher Allan Webber writes:

> Leo Famulari writes:
>
>> On Sat, Feb 13, 2016 at 01:55:01PM -0800, Christopher Allan Webber wrote:
>>> Christopher Allan Webber writes:
>>
>> [...]
>>
>>> >>> * gnu/packages/python.scm (python-wtforms, python2-wtforms): New variables.
>>> >>
>>> >> It looks good to me, but I wonder if the python-3 variant really needs
>>> >> setuptools? If so, okay. If not, can you use the new python2-variant
>>> >> system [0] to provide setuptools for python2-wtforms?
>>> >>
>>> >> [0] Introduced in 48b311b1b3ba
>>> >
>>> > Okay, I'll give that a try, and will make an adjustment if appropriate,
>>> > and regardless, push after figuring that out.
>>> >
>>> > Thanks to both of you!
>>> 
>>> Well, I think it's significant enough of a change where I should get
>>> some validation that everything looks right before I push.  New version,
>>> ahoy!  Is it ok?
>>
>> I believe that you still must call 'package-with-python2' in the
>> python-2 variant, and the argument to that should be
>> (strip-python2-variant python-foo).
>>
>> I've attached an example commit that seems to work, from one of my WIP
>> branches.
>
> Ah, you're right!  New patch!
>
>  - Chris

Leo also pointed out that the (name) redefinition might not be needed,
and indeed it wasn't!

And with that, pushed.  Whew!