From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCHES] Upgrade Kodi to 16.0
Date: Sun, 13 Mar 2016 10:24:06 +0100
Message-ID: <87vb4q4top.fsf@elephly.net>
References: <8760wrip2v.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87pouzfoeg.fsf@gnu.org>
	<CAJ=RwfZgSyhwnBMc89gxFb+nhdWWj6kLB1HR8W0_oaKQjZfmsg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1af2G2-00087e-Dz
	for guix-devel@gnu.org; Sun, 13 Mar 2016 05:24:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1af2Fy-0007pf-DZ
	for guix-devel@gnu.org; Sun, 13 Mar 2016 05:24:18 -0400
In-reply-to: <CAJ=RwfZgSyhwnBMc89gxFb+nhdWWj6kLB1HR8W0_oaKQjZfmsg@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>


Thompson, David <dthompson2@worcester.edu> writes:

> Hello Mathieu,
>
> On Sat, Mar 12, 2016 at 3:10 PM, Mathieu Lirzin <mthl@gnu.org> wrote:
>> Hello David,
>>
>> David Thompson <dthompson2@worcester.edu> writes:
>>
>>>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001
>>> From: David Thompson <dthompson2@worcester.edu>
>>> Date: Sat, 12 Mar 2016 12:23:47 -0500
>>> Subject: [PATCH 1/3] gnu: Add crossguid.
>>>
>>> * gnu/packages/kodi.scm (crossguid): New variable.
>>> ---
>> [...]
>>> +(define-public crossguid
>>> +  (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4"))
>>> +    (package
>>> +      (name "crossguid")
>>> +      (version (string-append "0.0-1." (string-take commit 7)))
>>> +      ;; There's no official release.  Just a Git repository.
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>> +                      (url "https://github.com/graeme-hill/crossguid.git")
>>> +                      (commit commit)))
>>> +                (sha256
>>> +                 (base32
>>> +                  "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk3s9"))))
>>
>> You have omitted “(file-name (string-append name "-" version ".tar.gz"))”.
>
> Not in this case because it's a git checkout, not a tarball download.

Shouldn’t it be named “...-checkout” then?  We do this a lot in the
bioinformatics.scm module.

~~ Ricardo