From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add MilkyTracker to Guix
Date: Mon, 28 Mar 2016 16:26:46 +0200
Message-ID: <87vb46ispl.fsf@elephly.net>
References: <6dae35698781717e6043be7086b6f63c@openmailbox.org>
	<20160327072337.GA13339@debian-netbook>
	<20160327230935.14e8ba5a@openmailbox.org>
	<87shzayj69.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1akYCY-0006V5-NK
	for guix-devel@gnu.org; Mon, 28 Mar 2016 10:31:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1akYCV-0008UZ-Gw
	for guix-devel@gnu.org; Mon, 28 Mar 2016 10:31:30 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1akYCV-0008TS-8m
	for guix-devel@gnu.org; Mon, 28 Mar 2016 10:31:27 -0400
In-reply-to: <87shzayj69.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org


Alex Kost <alezost@gmail.com> writes:

> Kei Yamashita (2016-03-28 06:09 +0300) wrote:
>
>> On Sun, 27 Mar 2016 10:23:37 +0300
>> Efraim Flashner <efraim@flashner.co.il> wrote:
>>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org wrote:
> [...]
>>> > +    (arguments
>>> > +     '(#:configure-flags `("--without-alsa" "--without-jack")))
>>>
>>> In addition to Nil's comments, I was wondering about the configure
>>> flags. Wouldn't it make sense to have either alsa or jack as an input?
>>
>> Milkytracker works fine without it on my machine. I feel like it's a
>> matter of allowing the user options or sticking to the minimal build.
>
> In my understanding (I may be wrong) our policy is to provide
> full-featured software, so the features shouldn't be disabled without a
> reason.  Sometimes we add minimal packages (e.g., "bash-minimal",
> "cups-minimal") if they are needed, but this is not such a case.
>
> So I think you should remove these --without-… flags.  And thanks for
> contributing!

I agree.  Also, JACK and ALSA are ubiquitous among Guix audio/music
packages.  When the programme comes with support for ALSA and JACK
backends by default I think we should not disable it.

~~ Ricardo