Re: [PATCH] Add vcflib.

[Roel Janssen <roel@gnu.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-filevercmp-v2.patch --]
[-- Type: text/x-patch, Size: 2053 bytes --]

From cda09da657bd18f21102b65729740b4819589ff9 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Mon, 25 Apr 2016 11:17:21 +0200
Subject: [PATCH] gnu: Add filevercmp.

* gnu/packages/bioinformatics.scm (filevercmp): New variable.
---
 gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 899ce1c..e973fff 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -5074,3 +5074,31 @@ negative binomial distribution to model the read counts among the samples in
 the same group, and look for consistent differences between ChIP and control
 group or two ChIP groups run under different conditions.")
     (license license:gpl3+)))
+
+(define-public filevercmp
+  (let ((commit "1a9b779b93d0b244040274794d402106907b71b7"))
+    (package
+      (name "filevercmp")
+      (version (string-append "0-1." (string-take commit 7)))
+      (source (origin
+        (method url-fetch)
+        (uri (string-append "https://github.com/ekg/filevercmp/archive/"
+                            commit ".tar.gz"))
+        (file-name (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32 "0yp5jswf5j2pqc6517x277s4s6h1ss99v57kxw9gy0jkfl3yh450"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests to run.
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure) ; There is no configure phase.
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
+                 (install-file "filevercmp" bin)))))))
+      (home-page "https://github.com/ekg/filevercmp")
+      (synopsis "This program compares version strings")
+      (description "This program compares version strings.  It intends to be a
+replacement for strverscmp.")
+      (license license:gpl3+))))
-- 
2.5.5


[-- Attachment #2: Type: text/plain, Size: 2241 bytes --]


Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Ricardo Wurmus writes:
>>
>>> Roel Janssen <roel@gnu.org> writes:
>>>
>>>> From f0cb8c476e902e3351988f7c278b3682837c8cce Mon Sep 17 00:00:00 2001
>>>> From: Roel Janssen <roel@gnu.org>
>>>> Date: Tue, 22 Mar 2016 15:47:06 +0100
>>>> Subject: [PATCH 5/8] gnu: Add filevercmp.
>>>
>>>> * gnu/packages/bioinformatics.scm (filevercmp): New variable.
>>>> ---
>>>>  gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++++++++
>>>>  1 file changed, 28 insertions(+)
>>>
>>>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>>>> index 0abccbc..261660f 100644
>>>> --- a/gnu/packages/bioinformatics.scm
>>>> +++ b/gnu/packages/bioinformatics.scm
>>>> @@ -4923,3 +4923,31 @@ combinatorial configurations.\" G Ehrlich - Journal of the ACM (JACM),
>>>>        (synopsis "Program for managing SOM (Self-Organizing Maps) neural networks")
>>>>        (description "Program for managing SOM (Self-Organizing Maps) neural networks.")
>>>>        (license license:gpl3))))
>>>> +
>>>> +(define-public filevercmp
>>>> +  (let ((commit "1a9b779b93d0b244040274794d402106907b71b7"))
>>>> +    (package
>>>> +      (name "filevercmp")
>>>> +      (version (string-append "0-1." (string-take commit 7)))
>>>> +      (source (origin
>>>> +        (method url-fetch)
>>>> +        (uri (string-append "https://github.com/ekg/filevercmp/archive/"
>>>> +                            commit ".tar.gz"))
>>>> +        (file-name "filevercmp-src.tar.gz")
>>>
>>> Is this on purpose?  Or should we use “(string-append name "-" version
>>> ".tar.gz")” instead?
>>
>> This is on purpose.  There is no released version.  Therefore I gave it
>> "version" 0, with a "-1" suffix for Guix, and the first seven characters
>> of commit hash.
>>
>> The download link includes the full commit hash.
>
> I see that my comment was ambiguous.  I meant the argument to
> “(file-name ...)”.  Instead of using “filevercmp-src.tar.gz” I think it
> would be better to include the generated version number by doing
> something like this:
>
>     (file-name (string-append name "-" version ".tar.gz"))

Oh, of course.  I attached an updated patch.

Kind regards,
Roel Janssen