From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 01/10] gnu: Add emacs-smex. Date: Thu, 02 Jun 2016 12:26:14 +0300 Message-ID: <87vb1slz61.fsf@gmail.com> References: <20160601140538.20311-1-dthompson2@worcester.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8OtZ-0008GE-Ca for guix-devel@gnu.org; Thu, 02 Jun 2016 05:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8OtU-0008Dq-EE for guix-devel@gnu.org; Thu, 02 Jun 2016 05:26:28 -0400 In-Reply-To: <20160601140538.20311-1-dthompson2@worcester.edu> (David Thompson's message of "Wed, 1 Jun 2016 10:05:29 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Thompson Cc: guix-devel@gnu.org, David Thompson David Thompson (2016-06-01 17:05 +0300) wrote: > From: David Thompson > > * gnu/packages/emacs.scm (emacs-smex): New variable. > --- > gnu/packages/emacs.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index b7c0a1f..71f2f8b 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -10,6 +10,7 @@ > ;;; Copyright =C2=A9 2015, 2016 Christopher Allan Webber > ;;; Copyright =C2=A9 2016 humanitiesNerd > ;;; Copyright =C2=A9 2016 Efraim Flashner > +;;; Copyright =C2=A9 2016 David Thompson > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.") > Emacs default configuration in uncontroversial ways that nearly everyone= can > agree upon.") > (license license:gpl3+))) > + > +(define-public emacs-smex > + (package > + (name "emacs-smex") > + (version "3.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://raw.githubusercontent.com" > + "/nonsequitur/smex/" version "/smex.el= ")) Hm, I see in some packages you use these "githubusercontent" URLs instead of as we usually do for github. IIUC you did it to avoid extra files (".gitignore", etc.) in the final package directory, right? If so, I think it is not needed, I would still use a link to a tagged source code archive. Moreover I think it's a problem of emacs-build-system that these uninteresting files are not removed. Overall, I don't mind against "githubusercontent", I was just wondering. Actually, I think you found a good way how to pick the needed files to make several packages from a single repo (as you did for "ido-ubiquitous" and "ido-completing-read+"). > + (file-name (string-append "smex-" version ".el")) > + (sha256 > + (base32 > + "0ar310zx9k5y4i1vl2rawvi712xj9gx77160860jbs691p77cxqp"))= )) > + (build-system emacs-build-system) > + (home-page "http://github.com/nonsequitur/smex/") > + (synopsis "M-x interface with Ido-style fuzzy matching") > + (description > + "Smex is a M-x enhancement for Emacs. Built on top of Ido, it prov= ides a > +convenient interface to your recently and most frequently used commands.= And > +to all the other commands, too.") > + (license license:gpl3+))) --=20 Alex