From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version. Date: Tue, 02 Aug 2016 14:44:14 +0200 Message-ID: <87vazjwdb5.fsf@gnu.org> References: <20160801181342.16203-1-david@craven.ch> <20160801181342.16203-9-david@craven.ch> <20160801195700.GD6728@solar> <20160801211739.GA6958@solar> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUZ3X-0008Mn-0w for guix-devel@gnu.org; Tue, 02 Aug 2016 08:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUZ3S-0001gA-UR for guix-devel@gnu.org; Tue, 02 Aug 2016 08:44:22 -0400 In-Reply-To: (David Craven's message of "Tue, 2 Aug 2016 13:57:25 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel David Craven skribis: >> Ups I just realized I made a mistake on this commit. > > What do you want me to do? not that I make things worse... This is > what I pushed. > > commit d26e2b9f306a1170d46f7c860c81840d9d600161 > Author: David Craven > Date: Mon Aug 1 16:39:00 2016 +0200 > > gnu: kde-frameworks: Remove kde-frameworks-version. > > * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variab= le. > (kwindowsystem)[version]: Replace kde-frameworks-version with > version string. > (oxygen-icons)[version]: Replace kde-frameworks-version with > version string. > > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-framework= s.scm > index 74fbac2..b60d85d 100644 > --- a/gnu/packages/kde-frameworks.scm > +++ b/gnu/packages/kde-frameworks.scm > @@ -27,8 +27,6 @@ > #:use-module (gnu packages qt) > #:use-module (gnu packages xorg)) > > -(define kde-frameworks-version "5.21.0") [...] > + (version "5.24.0") Mistake here, fixed in 7b5fc3a320eea930e6bc85a4d65c2ddbe0c9cffa. Now we should be all right. :-) Ludo=E2=80=99.