From: iyzsong@member.fsf.org (宋文武)
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/5] gnu: gtk+: Add "bin" output.
Date: Sun, 14 Aug 2016 14:21:21 +0800 [thread overview]
Message-ID: <87vaz327mm.fsf@member.fsf.org> (raw)
In-Reply-To: <20160813215107.70e34fb5@openmailbox.org> (Eric Bavier's message of "Sat, 13 Aug 2016 21:51:07 -0500")
Eric Bavier <ericbavier@openmailbox.org> writes:
> On Sat, 13 Aug 2016 22:21:53 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
>> On Sat, Aug 06, 2016 at 06:46:12PM +0800, 宋文武 wrote:
>> > * gnu/packages/gtk.scm (gtk+)[outputs]: New field.
>> > ---
>> > gnu/packages/gtk.scm | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>> > index 21365b9..5c42053 100644
>> > --- a/gnu/packages/gtk.scm
>> > +++ b/gnu/packages/gtk.scm
>> > @@ -624,6 +624,7 @@ application suites.")
>> > (base32
>> > "157nh9gg0p2avw765hrnkvr8lsh2w811397yxgjv6q5j4fzz6d1q"))
>> > (patches (search-patches "gtk3-respect-GUIX_GTK3_PATH.patch"))))
>> > + (outputs '("out" "bin" "doc"))
>> > (propagated-inputs
>> > `(("at-spi2-atk" ,at-spi2-atk)
>> > ("atk" ,atk)
>>
>> What effect does this have?
>>
>> Does Guix know to put something into the 'bin' output?
>
> Yes, the gnu-build-system will automatically pass '--bindir' to
> 'configure' if a "bin" output is present.
Yes, this will put 'gtk-update-icon-cache', 'gtk-encode-symbolic-svg',
'gtk3-dome', etc in the "bin" output.
>
> However, should these outputs not instead be added to the 'gtk+-2'
> package that 'gtk+' inherits from?
Yeah, but do it to 'gtk+-2' will fail with cycle references between
its "bin" and "out". So I just leave it untouched.
next prev parent reply other threads:[~2016-08-14 6:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 10:46 [PATCH 1/5] gnu: gtk+: Add "bin" output 宋文武
2016-08-06 10:46 ` [PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' from 'gtk+:bin' 宋文武
2016-08-14 2:17 ` Leo Famulari
2016-08-19 7:15 ` Mark H Weaver
2016-08-20 2:43 ` 宋文武
2016-08-20 18:56 ` Mark H Weaver
2016-08-06 10:46 ` [PATCH 3/5] gnu: evince: Don't install 'icon-theme.cache' 宋文武
2016-08-06 10:46 ` [PATCH 4/5] gnu: gnome-icon-theme, adwaita-icon-theme: " 宋文武
2016-08-14 2:15 ` Leo Famulari
2016-08-14 6:23 ` 宋文武
2016-08-06 10:46 ` [PATCH 5/5] gnu: gnome-themes-standard: " 宋文武
2016-08-14 2:21 ` [PATCH 1/5] gnu: gtk+: Add "bin" output Leo Famulari
2016-08-14 2:51 ` Eric Bavier
2016-08-14 6:21 ` 宋文武 [this message]
2016-08-23 12:11 ` 宋文武
2016-08-29 15:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaz327mm.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).