From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add capnproto.
Date: Sat, 20 Aug 2016 13:22:30 +0100 [thread overview]
Message-ID: <87vayv635l.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20160819221723.yqjsjb54jrfmxwmb@jasmine>
[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Fri, Aug 19, 2016 at 06:06:24PM -0400, Leo Famulari wrote:
>> On Sun, Aug 14, 2016 at 07:16:22PM +0100, Marius Bakke wrote:
>> > Leo Famulari <leo@famulari.name> writes:
>> >
>> > > On Sat, Aug 13, 2016 at 07:48:36PM +0100, Marius Bakke wrote:
>> > >> Note that it bundles googletest; I tried unbundling but it proved
>> > >> difficult. gtest will no longer be used from the 0.6 release so I did
>> > >> not think a comment was necessary.
>> > >
>> > > I am cc-ing Lukas with my reply, since he added our googletest package.
>> > > Maybe he has some insight.
>> > The problem is that their autotools system expects to build gtest as
>> > well, so there are references all over. See:
>> > https://github.com/sandstorm-io/capnproto/blob/release-0.5.3/c%2B%2B/Makefile.am
>> > and also configure.ac. It would have to be patched out, which seems
>> > excessive for a 4MB build dependency.
>>
>> In my opinion, it's generally not about the size of the bundled
>> dependency. Rather, it's about the opacity of the dependency graph of
>> the application that does the bundling. The worst case would be
>> something like a bundled OpenSSL, for example.
>>
>> In this case, Debian has accepted the bundled gtest [0], which makes me
>> wonder if my understanding of gtest is incorrect. Perhaps it is designed
>> to be bundled?
It comes bundled more often than not, but decoupling generally works out
of the box, as it's just linked to as with any library AFAICT:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md
If it was any other library, or if it wasn't dropped in current git, I
would have gone through the effort of purging it.
> In any case, since Debian accepted it, I'm willing to accept it as well,
> unless somebody objects.
>
> But the patch has gone stale due to other changes in serialization.scm.
> Marius, will you send an updated patch?
New patch below. Thanks!
[-- Attachment #2: 0001-gnu-Add-capnproto.patch --]
[-- Type: text/x-patch, Size: 2310 bytes --]
From 6e73e7c85a044d1da176534ed8ff046431afe617 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Fri, 12 Aug 2016 13:42:16 +0100
Subject: [PATCH] gnu: Add capnproto.
* gnu/packages/serialization.scm (capnproto): New variable.
---
gnu/packages/serialization.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index c3ce5c5..4a3278f 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
;;; Copyright © 2016 David Craven <david@craven.ch>
+;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -170,3 +171,32 @@ including serialization and deserialization to and from strings. It can also
preserve existing comment in unserialization/serialization steps, making
it a convenient format to store user input files.")
(license license:expat)))
+
+(define-public capnproto
+ (package
+ (name "capnproto")
+ (version "0.5.3")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://capnproto.org/capnproto-c++-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1yvaadhgakskqq5wpv53hd6fc3pp17mrdldw4i5cvgck4iwprcfd"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'do-not-require-/etc/services
+ (lambda _
+ ;; Workaround for test that tries to resolve port name from
+ ;; /etc/services, which is not present in build environment.
+ (substitute* "src/kj/async-io-test.c++" ((":http") ":80"))
+ #t)))))
+ (home-page "https://capnproto.org")
+ (synopsis "Capability-based RPC and serialization system")
+ (description
+ "Cap'n Proto is a very fast data interchange format and capability-based
+RPC system. Think JSON, except binary. Or think Protocol Buffers, except faster.")
+ (license license:expat)))
--
2.9.2
next prev parent reply other threads:[~2016-08-20 12:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 18:48 [PATCH] gnu: Add capnproto Marius Bakke
2016-08-14 17:17 ` Leo Famulari
2016-08-14 18:16 ` Marius Bakke
2016-08-19 22:06 ` Leo Famulari
2016-08-19 22:17 ` Leo Famulari
2016-08-20 12:22 ` Marius Bakke [this message]
2016-08-23 16:00 ` Leo Famulari
2016-08-23 18:30 ` Marius Bakke
2016-08-23 18:40 ` Leo Famulari
-- strict thread matches above, loose matches on Subject: below --
2016-08-25 8:04 Kenton Varda
2016-08-25 14:57 ` Marius Bakke
2016-08-25 17:22 ` Kenton Varda
2016-08-25 15:32 ` Alex Vong
2016-08-25 15:52 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vayv635l.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).