From: Marius Bakke <mbakke@fastmail.com>
To: Kenton Varda <kenton@sandstorm.io>,
leo@famulari.name, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add capnproto.
Date: Thu, 25 Aug 2016 15:57:08 +0100 [thread overview]
Message-ID: <87vayo28xn.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <CAOP=4wh+2__kbiRoHy0hdTtdhdRzE-d9fkUhh2mqoHwuK9=p9g@mail.gmail.com>
Kenton Varda <kenton@sandstorm.io> writes:
> Hi, Cap'n Proto upstream author here. Noticed this thread in a Google
> search, thought I'd comment.
>
> To shed some light on the googletest situation:
>
> The googletest maintainers have deemed that googletest should never
> ever be system-installed, and have even disabled `make install` in
> their build. See:
>
> https://github.com/google/googletest/blob/master/googletest/Makefile.am#L300
>
> I don't really understand what they think they're solving here but it
> is what it is and this seems to make it hard to use googletest in a
> non-bundled way. It's possible I misunderstood, though.
Hi, thanks for dropping in!
From reading the comments in the Makefile, apparently they are trying to
enforce something called the One-Definition Rule:
https://en.wikipedia.org/wiki/One_Definition_Rule
The way Guix (and actually most distro build systems) works makes it
impossible for another definition to "leak" into the build container, so
I don't understand either what they are trying to solve.
> FWIW, Cap'n Proto only uses googletest to build its tests. It does not
> install any artifacts that were influenced by googletest.
>
> In any case, this dependency will be gone once I find time to do the
> next release. Sorry for the trouble in the meantime.
No worries, can't blame you for bundling something clearly designed to
be bundled. It's usually easier to remove, though ;)
> PS. regarding the man page, I believe Debian mostly generated this
> page from the capnp tool's help text. I'd accept a patch to
> c++/src/kj/main.c++ which adds some code to generate man XML format
> directly, so that we don't have to maintain the same text in multiple
> places.
I'm guessing it's the issue I opened that sent you here :)
My C++ fu is not strong enough to embark on that journey, but maybe if
you mention it in the ticket someone may pick it up.
Thanks for the feedback!
Marius
next prev parent reply other threads:[~2016-08-25 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 8:04 [PATCH] gnu: Add capnproto Kenton Varda
2016-08-25 14:57 ` Marius Bakke [this message]
2016-08-25 17:22 ` Kenton Varda
2016-08-25 15:32 ` Alex Vong
2016-08-25 15:52 ` Marius Bakke
-- strict thread matches above, loose matches on Subject: below --
2016-08-13 18:48 Marius Bakke
2016-08-14 17:17 ` Leo Famulari
2016-08-14 18:16 ` Marius Bakke
2016-08-19 22:06 ` Leo Famulari
2016-08-19 22:17 ` Leo Famulari
2016-08-20 12:22 ` Marius Bakke
2016-08-23 16:00 ` Leo Famulari
2016-08-23 18:30 ` Marius Bakke
2016-08-23 18:40 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vayo28xn.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=kenton@sandstorm.io \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).