From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: Add mcelog.
Date: Wed, 14 Sep 2016 16:19:55 +0100
Message-ID: <87vaxybjac.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
References: <1473859239-8101-1-git-send-email-me@tobias.gr>
	<8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
	<a2f1c2c7-1a5c-f663-46b8-639bc802b5f7@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50519)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bkByx-0000gR-11
	for guix-devel@gnu.org; Wed, 14 Sep 2016 11:20:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bkByr-0006eF-L2
	for guix-devel@gnu.org; Wed, 14 Sep 2016 11:20:13 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bkByp-0006Yq-A4
	for guix-devel@gnu.org; Wed, 14 Sep 2016 11:20:09 -0400
In-Reply-To: <a2f1c2c7-1a5c-f663-46b8-639bc802b5f7@tobias.gr>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>, guix-devel@gnu.org

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> On 14/09/16 15:45, Marius Bakke wrote:
>> It's not visible in the cgit interface, but it actually seems to 
>> support normal snapshot downloads: 
>> https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz
>
> I did not know that. Thanks for the tip! It still requires a snippet,
> unfortunately.

Another thing, I think the snippet should be moved to a phase, as AFAIK
origin snippets should be reserved for removing unwanted files, or for
reproducibility. But, I may be wrong here.

>>> +    (home-page "http://mcelog.org/")
>> Nit-pick: the trailing slash is unnecessary :)
>
> Oh, I know, I just have a thing for proper root paths in URIs.
>
> I'm seeing someone about that.

This made me chuckle. Perhaps I should see someone about saving that
precious byte, too :)

Also, is DESTDIR supposed to be /share, shouldn't it be $out/share?
I think I'd define destdir as a variable, and use that also for the
etcprefix instead of using a make variable.

Thanks!
Marius