Re: [PATCH 2/2] gnu: lispf4: Fix the searchpath for SYSATOMS.

[Ricardo Wurmus <rekado@elephly.net>]

ng0 <ngillmann@runbox.com> writes:

> * gnu/packages/lisp.scm (lispf4)[arguments]: Fix the searchpath for SYSATOMS.
> ---
>  gnu/packages/lisp.scm | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index 7836d48..d66fb8b 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -474,8 +474,20 @@ interface.")
>           #:phases
>           (modify-phases %standard-phases
>             (delete 'configure)
> +           (add-before 'build 'fix-searchpath
> +             (lambda _
> +               (substitute* "Lispf42.f"
> +                 (("NAME='SYSATOMS'")
> +                  (string-append "NAME='" (assoc-ref %outputs "out")
> +                                 "/bin/SYSATOMS'")))
> +               (substitute* "lispf42.c"
> +                 (("SYSATOMS")
> +                  (string-append (assoc-ref %outputs "out") "/bin/SYSATOMS"))
> +                 ;;(("8+1") "72+8+1"))))
> +                 (("c_b98_st") "c_b98")
> +                 (("c_b98.val") ""))))
>             (replace 'install
> -            (lambda* (#:key outputs #:allow-other-keys)
> +             (lambda* (#:key outputs #:allow-other-keys)
>                (let* ((out (assoc-ref outputs "out"))
>                       (bin (string-append out "/bin"))
>                       (doc (string-append (assoc-ref outputs "doc")


Here’s an alternative:

           (add-before 'build 'fix-reference-to-SYSATOMS
             (lambda* (#:key outputs #:allow-other-keys)
               (substitute* "lispf42.c"
                 (("#define c_b98.*")
                  (string-append "#define c_b98 \""
                                 (assoc-ref outputs "out")
                                 "/bin/SYSATOMS\"\n")))
               #t))

This won’t work, however, because during the build phase the lispf4
executable is called to run a script.  At that point SYSATOMS only
exists in the current directory.  So with the above phase the build
would fail.

A hack to solve this would be to first install “SYSATOMS” to the target
directory and then build.

BTW: I think “SYSATOMS” and the “BASIC.IMG” should not be installed to
“bin” because they are not executables.  Instead they should go to
“$out/share/lispf4”.  This would also require you to change the code
that loads “BASIC.IMG” (I think it won’t work right now for the same
reasons as why you get the error relating to “SYSATOMS”.)

You also don’t seem to be installing “LISPF4.IMG”, which seems to be
required as well.

I should also note that after looking at the code I no longer consider
“lispf42.c” to be source code.  It’s unreadable because it’s the
automatically produced output of a fortran-to-C converter, only slightly
modified :-/

~~ Ricardo