From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: Display diffs between generations. Date: Wed, 26 Oct 2016 14:58:31 +0200 Message-ID: <87vawf9si0.fsf@gnu.org> References: <87eg59izmw.fsf@gnu.org> <87d1kry22u.fsf@gnu.org> <87inuj5r5v.fsf@gnu.org> <87y43ck6dz.fsf@gnu.org> <87a8frq0n5.fsf@gnu.org> <87lgz78v4d.fsf@gnu.org> <87eg3ogd5l.fsf@gnu.org> <87r37nxshp.fsf@gnu.org> <8760opeskj.fsf@gnu.org> <87wph43x8x.fsf@gnu.org> <87vawo57sn.fsf@gnu.org> <87funrci3f.fsf@gnu.org> <87k2d3p4bf.fsf@gnu.org> <87wph2zu8z.fsf@gnu.org> <87oa2eqc03.fsf@gnu.org> <20161021164053.2961bd6d@gondolin.arda> <877f8x1o7j.fsf@gnu.org> <87twc08lkc.fsf@gnu.org> <20161026131310.5e1c0994@gondolin.arda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzNlf-0000vK-Hq for guix-devel@gnu.org; Wed, 26 Oct 2016 08:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzNla-0001pP-Rj for guix-devel@gnu.org; Wed, 26 Oct 2016 08:57:19 -0400 In-reply-to: <20161026131310.5e1c0994@gondolin.arda> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Benz Schenk Cc: guix-devel Benz Schenk writes: > On Tue, 25 Oct 2016 18:01:23 +0200 > Roel Janssen wrote: > >> Ludovic Courtès writes: >> >> > Hi! >> > >> > Benz Schenk skribis: >> > >> >> On Fri, 21 Oct 2016 11:37:00 +0200 >> >> Roel Janssen wrote: >> > >> > [...] >> > >> [...] >> >> >> >> I adapted your patch to hopefully implement the desired behaviour, but >> >> it might need some cleaning up as I'm just getting started learning >> >> scheme. >> > >> >>From what I can see that Benz’ patch does indeed work as expected (but >> > really, the example above is a corner case that we shouldn’t worry too >> > much about.) >> > >> > Roel, if that’s fine with you, please commit with proper commit log and >> > acknowledgment. >> > >> > Thanks to both of you. :-) >> >> Thanks a lot Benz! >> >> There's only one thing: >> Would it make more sense to stick to the chronology of the generations >> (sorting them before displaying them)? > > IMO it's useful to see the diffs in reverse when before switching > to some previous generation, although you can easily see the changes > no matter how you order the generations, so I don't really have a strong > opinion either way. > >> >> >> If you think Benz's patch is good, then I will push that one. Otherwise >> I'll adapt it to sort the generations. >> >> @Benz, what's the copyright line you want to have in the patch? > > I guess > Copyright © 2016 Benz Schenk > >> >> Kind regards, >> Roel Janssen > > Kind regards, > Benz Schenk > > PS: > > @Roel Janssen, sorry for double-posting I forgot to cc guix-devel > > @everyone > on the bright side, I updated the patch to use display-generation > instead of the copy+pasted mess I created in the last patch and added > my copyright lines. Thanks! I pushed the patch with some more minor clean-ups. Kind regards, Roel Janssen